Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2879)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add {} Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 7678bd6bd9f13e1916ad58b013ea8b23572b8a9e..b2fab16a4c1b20c906242e43f0470a3ea57cc52a 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -829,7 +829,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
const ExtensionSet& enabled_set = registry->enabled_extensions();
for (ExtensionSet::const_iterator extension = enabled_set.begin();
extension != enabled_set.end(); ++extension) {
- if (ui_util::ShouldDisplayInExtensionSettings(*extension, profile)) {
+ if (ui_util::ShouldDisplayInExtensionSettings(extension->get(), profile)) {
extensions_list->Append(CreateExtensionDetailValue(
extension->get(),
GetInspectablePagesForExtension(extension->get(), true),
@@ -839,7 +839,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
const ExtensionSet& disabled_set = registry->disabled_extensions();
for (ExtensionSet::const_iterator extension = disabled_set.begin();
extension != disabled_set.end(); ++extension) {
- if (ui_util::ShouldDisplayInExtensionSettings(*extension, profile)) {
+ if (ui_util::ShouldDisplayInExtensionSettings(extension->get(), profile)) {
extensions_list->Append(CreateExtensionDetailValue(
extension->get(),
GetInspectablePagesForExtension(extension->get(), false),
@@ -850,7 +850,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
std::vector<ExtensionPage> empty_pages;
for (ExtensionSet::const_iterator extension = terminated_set.begin();
extension != terminated_set.end(); ++extension) {
- if (ui_util::ShouldDisplayInExtensionSettings(*extension, profile)) {
+ if (ui_util::ShouldDisplayInExtensionSettings(extension->get(), profile)) {
extensions_list->Append(CreateExtensionDetailValue(
extension->get(),
empty_pages, // Terminated process has no active pages.

Powered by Google App Engine
This is Rietveld 408576698