Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

chrome/browser/ui/location_bar/location_bar.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/location_bar/location_bar.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/permissions/permissions_data.h"
 
 
 LocationBar::LocationBar(Profile* profile) : profile_(profile) {
 }
 
 LocationBar::~LocationBar() {
 }
 
 bool LocationBar::IsBookmarkStarHiddenByExtension() const {
   const extensions::ExtensionSet& extension_set =
       extensions::ExtensionRegistry::Get(profile_)->enabled_extensions();
   for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
        i != extension_set.end(); ++i) {
-    if (extensions::UIOverrides::RemovesBookmarkButton(*i) &&
+    if (extensions::UIOverrides::RemovesBookmarkButton(i->get()) &&
         ((*i)->permissions_data()->HasAPIPermission(

[msw, 2014/08/26 23:39:24]

q: did you intend to fix this (*i) too?

[dcheng, 2014/08/26 23:45:09]

Technically, I don't think this one needs to be rewritten: the *i gives you a
scoped_refptr, and then we use scoped_refptr's operator->. So it's just a matter
of aesthetics:
(*i)->
vs
i->get()->

((*i)-> is shorter and less work for me =)

[msw, 2014/08/27 00:02:39]

Acknowledged.

              extensions::APIPermission::kBookmarkManagerPrivate) ||
          extensions::FeatureSwitch::enable_override_bookmarks_ui()
              ->IsEnabled()))
       return true;
   }
 
   return false;
 }