Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in extensions/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/7921e3faac8556ad9e24c533b8019f85b99e6911 Cr-Commit-Position: refs/heads/master@{#291770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -89 lines) Patch
M extensions/browser/api/cast_channel/cast_socket_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/serial/serial_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M extensions/browser/api/usb_private/usb_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_protocols.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_registry_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/info_map.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/runtime_data_unittest.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M extensions/browser/test_extension_registry_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_set_unittest.cc View 2 chunks +17 lines, -12 lines 0 comments Download
M extensions/common/manifest_handlers/file_handler_manifest_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/common/permissions/permissions_data_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/renderer/api/serial/data_receiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api/serial/data_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api/serial/serial_api_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
6 years, 4 months ago (2014-08-25 19:43:55 UTC) #1
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-25 20:35:40 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-25 21:07:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503873002/1
6 years, 4 months ago (2014-08-25 21:09:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-25 21:44:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 313125c73cf46fb78b384adb6e57e782f358aaaf
6 years, 4 months ago (2014-08-25 22:20:26 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7921e3faac8556ad9e24c533b8019f85b99e6911
Cr-Commit-Position: refs/heads/master@{#291770}

Powered by Google App Engine
This is Rietveld 408576698