Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: extensions/browser/runtime_data_unittest.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/process_manager.cc ('k') | extensions/browser/test_extension_registry_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/runtime_data_unittest.cc
diff --git a/extensions/browser/runtime_data_unittest.cc b/extensions/browser/runtime_data_unittest.cc
index 913aed3293c8ec2820e9c39bce85d1a335aff7e2..23b8098fb55515822a0f8f3eaddc7d281f8b1ef5 100644
--- a/extensions/browser/runtime_data_unittest.cc
+++ b/extensions/browser/runtime_data_unittest.cc
@@ -53,55 +53,55 @@ class RuntimeDataTest : public testing::Test {
TEST_F(RuntimeDataTest, IsBackgroundPageReady) {
// An extension without a background page is always considered ready.
scoped_refptr<Extension> no_background = CreateExtension();
- EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(no_background));
+ EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(no_background.get()));
// An extension with a background page is not ready until the flag is set.
scoped_refptr<Extension> with_background =
CreateExtensionWithBackgroundPage();
- EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background));
+ EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background.get()));
// The flag can be toggled.
- runtime_data_.SetBackgroundPageReady(with_background, true);
- EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(with_background));
- runtime_data_.SetBackgroundPageReady(with_background, false);
- EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background));
+ runtime_data_.SetBackgroundPageReady(with_background.get(), true);
+ EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(with_background.get()));
+ runtime_data_.SetBackgroundPageReady(with_background.get(), false);
+ EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background.get()));
}
TEST_F(RuntimeDataTest, IsBeingUpgraded) {
scoped_refptr<Extension> extension = CreateExtension();
// An extension is not being upgraded until the flag is set.
- EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension));
+ EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension.get()));
// The flag can be toggled.
- runtime_data_.SetBeingUpgraded(extension, true);
- EXPECT_TRUE(runtime_data_.IsBeingUpgraded(extension));
- runtime_data_.SetBeingUpgraded(extension, false);
- EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension));
+ runtime_data_.SetBeingUpgraded(extension.get(), true);
+ EXPECT_TRUE(runtime_data_.IsBeingUpgraded(extension.get()));
+ runtime_data_.SetBeingUpgraded(extension.get(), false);
+ EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension.get()));
}
TEST_F(RuntimeDataTest, HasUsedWebRequest) {
scoped_refptr<Extension> extension = CreateExtension();
// An extension has not used web request until the flag is set.
- EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension));
+ EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension.get()));
// The flag can be toggled.
- runtime_data_.SetHasUsedWebRequest(extension, true);
- EXPECT_TRUE(runtime_data_.HasUsedWebRequest(extension));
- runtime_data_.SetHasUsedWebRequest(extension, false);
- EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension));
+ runtime_data_.SetHasUsedWebRequest(extension.get(), true);
+ EXPECT_TRUE(runtime_data_.HasUsedWebRequest(extension.get()));
+ runtime_data_.SetHasUsedWebRequest(extension.get(), false);
+ EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension.get()));
}
// Unloading an extension stops tracking it.
TEST_F(RuntimeDataTest, OnExtensionUnloaded) {
scoped_refptr<Extension> extension = CreateExtensionWithBackgroundPage();
- runtime_data_.SetBackgroundPageReady(extension, true);
- ASSERT_TRUE(runtime_data_.HasExtensionForTesting(extension));
+ runtime_data_.SetBackgroundPageReady(extension.get(), true);
+ ASSERT_TRUE(runtime_data_.HasExtensionForTesting(extension.get()));
runtime_data_.OnExtensionUnloaded(
- NULL, extension, UnloadedExtensionInfo::REASON_DISABLE);
- EXPECT_FALSE(runtime_data_.HasExtensionForTesting(extension));
+ NULL, extension.get(), UnloadedExtensionInfo::REASON_DISABLE);
+ EXPECT_FALSE(runtime_data_.HasExtensionForTesting(extension.get()));
}
} // namespace
« no previous file with comments | « extensions/browser/process_manager.cc ('k') | extensions/browser/test_extension_registry_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698