extensions/browser/api/serial/serial_apitest.cc - Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_apitest.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/serial/serial_apitest.cc

diff --git a/extensions/browser/api/serial/serial_apitest.cc b/extensions/browser/api/serial/serial_apitest.cc

index 4d81286fa0703e3fb30463f0849d871baf3e9ec9..22089c9cfbd1a958c975f783fa74ae41484e0fb0 100644

--- a/extensions/browser/api/serial/serial_apitest.cc

+++ b/extensions/browser/api/serial/serial_apitest.cc

@@ -71,7 +71,7 @@ class FakeSerialConnectFunction : public core_api::SerialConnectFunction {

const std::string& owner_extension_id) const OVERRIDE {

scoped_refptr<FakeEchoSerialIoHandler> io_handler =

new FakeEchoSerialIoHandler;

- EXPECT_CALL(*io_handler, SetControlSignals(_)).Times(1).WillOnce(

+ EXPECT_CALL(*io_handler.get(), SetControlSignals(_)).Times(1).WillOnce(

Return(true));

SerialConnection* serial_connection =

new SerialConnection(port, owner_extension_id);

« no previous file with comments | « extensions/browser/api/hid/hid_api.cc ('k') | extensions/browser/api/usb/usb_api.cc » ('j') | no next file with comments »