Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: extensions/browser/extension_registry_unittest.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_protocols.cc ('k') | extensions/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_registry_unittest.cc
diff --git a/extensions/browser/extension_registry_unittest.cc b/extensions/browser/extension_registry_unittest.cc
index 492bcb05b31410ac99f4cf485f1f3933a0332a2a..6eaf59032aaa8a18c9ab8b5b901288b6f63798c3 100644
--- a/extensions/browser/extension_registry_unittest.cc
+++ b/extensions/browser/extension_registry_unittest.cc
@@ -27,7 +27,7 @@ testing::AssertionResult HasSingleExtension(
return testing::AssertionFailure() << list.size()
<< " extensions, expected 1";
const Extension* did_load = list[0].get();
- if (did_load != extension)
+ if (did_load != extension.get())
return testing::AssertionFailure() << "Expected " << extension->id()
<< " found " << did_load->id();
return testing::AssertionSuccess();
@@ -248,26 +248,27 @@ TEST_F(ExtensionRegistryTest, Observer) {
test_util::CreateExtensionWithID("id");
registry.TriggerOnWillBeInstalled(
- extension, false, false, base::EmptyString());
+ extension.get(), false, false, base::EmptyString());
EXPECT_TRUE(HasSingleExtension(observer.installed(), extension.get()));
registry.AddEnabled(extension);
- registry.TriggerOnLoaded(extension);
+ registry.TriggerOnLoaded(extension.get());
- registry.TriggerOnWillBeInstalled(extension, true, false, "foo");
+ registry.TriggerOnWillBeInstalled(extension.get(), true, false, "foo");
EXPECT_TRUE(HasSingleExtension(observer.loaded(), extension.get()));
EXPECT_TRUE(observer.unloaded().empty());
registry.Shutdown();
registry.RemoveEnabled(extension->id());
- registry.TriggerOnUnloaded(extension, UnloadedExtensionInfo::REASON_DISABLE);
+ registry.TriggerOnUnloaded(extension.get(),
+ UnloadedExtensionInfo::REASON_DISABLE);
EXPECT_TRUE(observer.loaded().empty());
EXPECT_TRUE(HasSingleExtension(observer.unloaded(), extension.get()));
registry.Shutdown();
- registry.TriggerOnUninstalled(extension,
+ registry.TriggerOnUninstalled(extension.get(),
extensions::UNINSTALL_REASON_FOR_TESTING);
EXPECT_TRUE(observer.installed().empty());
EXPECT_TRUE(HasSingleExtension(observer.uninstalled(), extension.get()));
« no previous file with comments | « extensions/browser/extension_protocols.cc ('k') | extensions/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698