Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Side by Side Diff: extensions/browser/runtime_data_unittest.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/runtime_data.h" 5 #include "extensions/browser/runtime_data.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "extensions/browser/extension_registry.h" 10 #include "extensions/browser/extension_registry.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 ExtensionRegistry registry_; 46 ExtensionRegistry registry_;
47 RuntimeData runtime_data_; 47 RuntimeData runtime_data_;
48 48
49 private: 49 private:
50 DISALLOW_COPY_AND_ASSIGN(RuntimeDataTest); 50 DISALLOW_COPY_AND_ASSIGN(RuntimeDataTest);
51 }; 51 };
52 52
53 TEST_F(RuntimeDataTest, IsBackgroundPageReady) { 53 TEST_F(RuntimeDataTest, IsBackgroundPageReady) {
54 // An extension without a background page is always considered ready. 54 // An extension without a background page is always considered ready.
55 scoped_refptr<Extension> no_background = CreateExtension(); 55 scoped_refptr<Extension> no_background = CreateExtension();
56 EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(no_background)); 56 EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(no_background.get()));
57 57
58 // An extension with a background page is not ready until the flag is set. 58 // An extension with a background page is not ready until the flag is set.
59 scoped_refptr<Extension> with_background = 59 scoped_refptr<Extension> with_background =
60 CreateExtensionWithBackgroundPage(); 60 CreateExtensionWithBackgroundPage();
61 EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background)); 61 EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background.get()));
62 62
63 // The flag can be toggled. 63 // The flag can be toggled.
64 runtime_data_.SetBackgroundPageReady(with_background, true); 64 runtime_data_.SetBackgroundPageReady(with_background.get(), true);
65 EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(with_background)); 65 EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(with_background.get()));
66 runtime_data_.SetBackgroundPageReady(with_background, false); 66 runtime_data_.SetBackgroundPageReady(with_background.get(), false);
67 EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background)); 67 EXPECT_FALSE(runtime_data_.IsBackgroundPageReady(with_background.get()));
68 } 68 }
69 69
70 TEST_F(RuntimeDataTest, IsBeingUpgraded) { 70 TEST_F(RuntimeDataTest, IsBeingUpgraded) {
71 scoped_refptr<Extension> extension = CreateExtension(); 71 scoped_refptr<Extension> extension = CreateExtension();
72 72
73 // An extension is not being upgraded until the flag is set. 73 // An extension is not being upgraded until the flag is set.
74 EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension)); 74 EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension.get()));
75 75
76 // The flag can be toggled. 76 // The flag can be toggled.
77 runtime_data_.SetBeingUpgraded(extension, true); 77 runtime_data_.SetBeingUpgraded(extension.get(), true);
78 EXPECT_TRUE(runtime_data_.IsBeingUpgraded(extension)); 78 EXPECT_TRUE(runtime_data_.IsBeingUpgraded(extension.get()));
79 runtime_data_.SetBeingUpgraded(extension, false); 79 runtime_data_.SetBeingUpgraded(extension.get(), false);
80 EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension)); 80 EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension.get()));
81 } 81 }
82 82
83 TEST_F(RuntimeDataTest, HasUsedWebRequest) { 83 TEST_F(RuntimeDataTest, HasUsedWebRequest) {
84 scoped_refptr<Extension> extension = CreateExtension(); 84 scoped_refptr<Extension> extension = CreateExtension();
85 85
86 // An extension has not used web request until the flag is set. 86 // An extension has not used web request until the flag is set.
87 EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension)); 87 EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension.get()));
88 88
89 // The flag can be toggled. 89 // The flag can be toggled.
90 runtime_data_.SetHasUsedWebRequest(extension, true); 90 runtime_data_.SetHasUsedWebRequest(extension.get(), true);
91 EXPECT_TRUE(runtime_data_.HasUsedWebRequest(extension)); 91 EXPECT_TRUE(runtime_data_.HasUsedWebRequest(extension.get()));
92 runtime_data_.SetHasUsedWebRequest(extension, false); 92 runtime_data_.SetHasUsedWebRequest(extension.get(), false);
93 EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension)); 93 EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension.get()));
94 } 94 }
95 95
96 // Unloading an extension stops tracking it. 96 // Unloading an extension stops tracking it.
97 TEST_F(RuntimeDataTest, OnExtensionUnloaded) { 97 TEST_F(RuntimeDataTest, OnExtensionUnloaded) {
98 scoped_refptr<Extension> extension = CreateExtensionWithBackgroundPage(); 98 scoped_refptr<Extension> extension = CreateExtensionWithBackgroundPage();
99 runtime_data_.SetBackgroundPageReady(extension, true); 99 runtime_data_.SetBackgroundPageReady(extension.get(), true);
100 ASSERT_TRUE(runtime_data_.HasExtensionForTesting(extension)); 100 ASSERT_TRUE(runtime_data_.HasExtensionForTesting(extension.get()));
101 101
102 runtime_data_.OnExtensionUnloaded( 102 runtime_data_.OnExtensionUnloaded(
103 NULL, extension, UnloadedExtensionInfo::REASON_DISABLE); 103 NULL, extension.get(), UnloadedExtensionInfo::REASON_DISABLE);
104 EXPECT_FALSE(runtime_data_.HasExtensionForTesting(extension)); 104 EXPECT_FALSE(runtime_data_.HasExtensionForTesting(extension.get()));
105 } 105 }
106 106
107 } // namespace 107 } // namespace
108 } // namespace extensions 108 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/process_manager.cc ('k') | extensions/browser/test_extension_registry_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698