Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: extensions/common/extension_set_unittest.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_set_unittest.cc
diff --git a/extensions/common/extension_set_unittest.cc b/extensions/common/extension_set_unittest.cc
index 75a69de5f1c63b7e796705878a9ff87fd4b2350a..54be17ff0b362c4a06444e48de2db55b659c4119 100644
--- a/extensions/common/extension_set_unittest.cc
+++ b/extensions/common/extension_set_unittest.cc
@@ -69,12 +69,12 @@ TEST(ExtensionSetTest, ExtensionSet) {
// Add an extension.
EXPECT_TRUE(extensions.Insert(ext1));
EXPECT_EQ(1u, extensions.size());
- EXPECT_EQ(ext1, extensions.GetByID(ext1->id()));
+ EXPECT_EQ(ext1.get(), extensions.GetByID(ext1->id()));
// Since extension2 has same ID, it should overwrite extension1.
EXPECT_FALSE(extensions.Insert(ext2));
EXPECT_EQ(1u, extensions.size());
- EXPECT_EQ(ext2, extensions.GetByID(ext1->id()));
+ EXPECT_EQ(ext2.get(), extensions.GetByID(ext1->id()));
// Add the other extensions.
EXPECT_TRUE(extensions.Insert(ext3));
@@ -82,18 +82,23 @@ TEST(ExtensionSetTest, ExtensionSet) {
EXPECT_EQ(3u, extensions.size());
// Get extension by its chrome-extension:// URL
- EXPECT_EQ(ext2, extensions.GetExtensionOrAppByURL(
- ext2->GetResourceURL("test.html")));
- EXPECT_EQ(ext3, extensions.GetExtensionOrAppByURL(
- ext3->GetResourceURL("test.html")));
- EXPECT_EQ(ext4, extensions.GetExtensionOrAppByURL(
- ext4->GetResourceURL("test.html")));
+ EXPECT_EQ(
+ ext2.get(),
+ extensions.GetExtensionOrAppByURL(ext2->GetResourceURL("test.html")));
+ EXPECT_EQ(
+ ext3.get(),
+ extensions.GetExtensionOrAppByURL(ext3->GetResourceURL("test.html")));
+ EXPECT_EQ(
+ ext4.get(),
+ extensions.GetExtensionOrAppByURL(ext4->GetResourceURL("test.html")));
// Get extension by web extent.
- EXPECT_EQ(ext2, extensions.GetExtensionOrAppByURL(
- GURL("http://code.google.com/p/chromium/monkey")));
- EXPECT_EQ(ext3, extensions.GetExtensionOrAppByURL(
- GURL("http://dev.chromium.org/design-docs/")));
+ EXPECT_EQ(ext2.get(),
+ extensions.GetExtensionOrAppByURL(
+ GURL("http://code.google.com/p/chromium/monkey")));
+ EXPECT_EQ(ext3.get(),
+ extensions.GetExtensionOrAppByURL(
+ GURL("http://dev.chromium.org/design-docs/")));
EXPECT_FALSE(extensions.GetExtensionOrAppByURL(
GURL("http://blog.chromium.org/")));

Powered by Google App Engine
This is Rietveld 408576698