extensions/browser/api/hid/hid_api.cc - Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 503873002: Remove implicit conversions from scoped_refptr to T* in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_socket_unittest.cc ('k') | extensions/browser/api/serial/serial_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/hid/hid_api.cc

diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc

index 3f0e25829a5e6b897703fa69aa653cab3b7157b5..208af12f35c3aecc59e0e05f54b5e1add9df4d37 100644

--- a/extensions/browser/api/hid/hid_api.cc

+++ b/extensions/browser/api/hid/hid_api.cc

@@ -131,7 +131,7 @@ void HidConnectFunction::AsyncWorkStart() {

DCHECK(hid_service);

scoped_refptr<HidConnection> connection =

hid_service->Connect(device_info.device_id);

- if (!connection) {

+ if (!connection.get()) {

CompleteWithError(kErrorFailedToOpenDevice);

return;

}

« no previous file with comments | « extensions/browser/api/cast_channel/cast_socket_unittest.cc ('k') | extensions/browser/api/serial/serial_apitest.cc » ('j') | no next file with comments »