Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed)

Created:
6 years, 4 months ago by nweiz
Modified:
6 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't load assets unnecessarily when precompiling executables. R=rnystrom@google.com BUG=20482 Committed: https://code.google.com/p/dart/source/detail?r=39528

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+788 lines, -695 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart View 6 chunks +27 lines, -12 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/build.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/executable.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/build/copies_non_dart_files_to_build_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/adds_latest_matching_version_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/adds_latest_version_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/all_adds_all_matching_versions_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/all_with_some_versions_present_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/already_cached_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/no_matching_version_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/package_not_found_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/cache/repair/handles_failure_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/repair/reinstalls_hosted_packages_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/dependency_override_test.dart View 1 4 chunks +20 lines, -18 lines 0 comments Download
M sdk/lib/_internal/pub/test/deps_test.dart View 1 1 chunk +13 lines, -23 lines 0 comments Download
M sdk/lib/_internal/pub/test/downgrade/does_not_show_other_versions_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/downgrade/dry_run_does_not_apply_changes_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/downgrade/unlock_dependers_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/downgrade/unlock_if_necessary_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/dry_run_does_not_apply_changes_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/cached_pubspec_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/do_not_upgrade_on_removed_constraints_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/does_no_network_requests_when_possible_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/get_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/get_transitive_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/resolve_constraints_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/stay_locked_if_compatible_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 2 chunks +11 lines, -11 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/stay_locked_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/unlock_if_incompatible_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 2 chunks +13 lines, -13 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/unlock_if_version_doesnt_exist_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/switch_source_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/activate_git_after_hosted_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/activate_hosted_after_git_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/activate_hosted_after_path_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/activate_path_after_hosted_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/cached_package_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/constraint_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/different_version_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/empty_constraint_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/ignores_active_version_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/installs_dependencies_for_git_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/installs_dependencies_for_path_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/installs_dependencies_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/uncached_package_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/unknown_package_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/global/deactivate/deactivate_and_reactivate_package_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/deactivate/hosted_package_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/deactivate/unknown_package_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/global/list_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/run/implicit_executable_name_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/run/nonexistent_script_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/global/run/runs_script_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/run/unknown_package_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/offline_test.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_dependency_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_transitive_dependency_test.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart View 1 6 chunks +37 lines, -37 lines 0 comments Download
M sdk/lib/_internal/pub/test/implicit_dependency_test.dart View 1 4 chunks +26 lines, -26 lines 0 comments Download
M sdk/lib/_internal/pub/test/list_package_dirs/lists_dependency_directories_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/no_package_symlinks_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/gets_first_if_dependency_is_not_installed_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/gets_first_if_transitive_dependency_is_not_installed_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A sdk/lib/_internal/pub/test/serve_packages.dart View 1 1 chunk +195 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/creates_a_snapshot_for_immediate_and_transitive_dep_test.dart View 1 1 chunk +12 lines, -12 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/creates_a_snapshot_test.dart View 1 1 chunk +11 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/doesnt_resnapshot_when_a_dependency_is_unchanged_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_an_entrypoint_dependency_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/prints_errors_for_broken_snapshots_test.dart View 1 1 chunk +14 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/recompiles_if_the_sdk_is_out_of_date_test.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/snapshots_transformed_code_test.dart View 1 1 chunk +13 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/upgrades_snapshot_for_dependency_test.dart View 1 2 chunks +17 lines, -15 lines 0 comments Download
M sdk/lib/_internal/pub/test/snapshot/upgrades_snapshot_test.dart View 1 2 chunks +14 lines, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 1 3 chunks +4 lines, -134 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/dry_run_does_not_apply_changes_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/hosted/unlock_dependers_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/hosted/unlock_if_necessary_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/hosted/upgrade_removed_constraints_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/report/describes_change_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/report/does_not_show_newer_versions_for_locked_packages_test.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/report/highlights_overrides_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/report/leading_character_shows_change_test.dart View 1 1 chunk +11 lines, -11 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/report/shows_newer_available_versions_test.dart View 1 1 chunk +17 lines, -17 lines 0 comments Download
M sdk/lib/_internal/pub/test/upgrade/report/shows_number_of_changed_dependencies_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 4 months ago (2014-08-21 01:30:32 UTC) #1
Bob Nystrom
LGTM. https://codereview.chromium.org/494943002/diff/1/sdk/lib/_internal/pub/lib/src/executable.dart File sdk/lib/_internal/pub/lib/src/executable.dart (right): https://codereview.chromium.org/494943002/diff/1/sdk/lib/_internal/pub/lib/src/executable.dart#newcode69 sdk/lib/_internal/pub/lib/src/executable.dart:69: useDart2JS: false).then((_environment) { Add a TODO that we ...
6 years, 4 months ago (2014-08-21 21:42:48 UTC) #2
nweiz
Code review changes
6 years, 4 months ago (2014-08-25 19:45:48 UTC) #3
nweiz
https://codereview.chromium.org/494943002/diff/1/sdk/lib/_internal/pub/lib/src/executable.dart File sdk/lib/_internal/pub/lib/src/executable.dart (right): https://codereview.chromium.org/494943002/diff/1/sdk/lib/_internal/pub/lib/src/executable.dart#newcode69 sdk/lib/_internal/pub/lib/src/executable.dart:69: useDart2JS: false).then((_environment) { On 2014/08/21 21:42:48, Bob Nystrom wrote: ...
6 years, 4 months ago (2014-08-25 19:46:49 UTC) #4
nweiz
6 years, 4 months ago (2014-08-25 19:47:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as 39528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698