Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: sdk/lib/_internal/pub/test/implicit_dependency_test.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'descriptor.dart' as d; 5 import 'descriptor.dart' as d;
6 import 'test_pub.dart'; 6 import 'test_pub.dart';
7 import '../lib/src/barback.dart' as barback; 7 import '../lib/src/barback.dart' as barback;
8 import '../lib/src/version.dart'; 8 import '../lib/src/version.dart';
9 9
10 main() { 10 main() {
11 initConfig(); 11 initConfig();
12 12
13 forBothPubGetAndUpgrade((command) { 13 forBothPubGetAndUpgrade((command) {
14 integration("implicitly constrains it to versions pub supports", () { 14 integration("implicitly constrains it to versions pub supports", () {
15 servePackages([ 15 servePackages((builder) {
16 packageMap("barback", current("barback")), 16 builder.serve("barback", current("barback"));
17 packageMap("stack_trace", previous("stack_trace")), 17 builder.serve("stack_trace", previous("stack_trace"));
18 packageMap("stack_trace", current("stack_trace")), 18 builder.serve("stack_trace", current("stack_trace"));
19 packageMap("stack_trace", nextPatch("stack_trace")), 19 builder.serve("stack_trace", nextPatch("stack_trace"));
20 packageMap("stack_trace", max("stack_trace")), 20 builder.serve("stack_trace", max("stack_trace"));
21 packageMap("source_span", current("source_span")) 21 builder.serve("source_span", current("source_span"));
22 ]); 22 });
23 23
24 d.appDir({ 24 d.appDir({
25 "barback": "any" 25 "barback": "any"
26 }).create(); 26 }).create();
27 27
28 pubCommand(command); 28 pubCommand(command);
29 29
30 d.packagesDir({"stack_trace": nextPatch("stack_trace")}).validate(); 30 d.packagesDir({"stack_trace": nextPatch("stack_trace")}).validate();
31 }); 31 });
32 32
33 integration("pub's implicit constraint uses the same source and " 33 integration("pub's implicit constraint uses the same source and "
34 "description as a dependency override", () { 34 "description as a dependency override", () {
35 servePackages([ 35 servePackages((builder) {
36 packageMap("barback", current("barback")), 36 builder.serve("barback", current("barback"));
37 packageMap("stack_trace", nextPatch("stack_trace")), 37 builder.serve("stack_trace", nextPatch("stack_trace"));
38 packageMap("source_span", current("source_span")) 38 builder.serve("source_span", current("source_span"));
39 ]); 39 });
40 40
41 d.dir("stack_trace", [ 41 d.dir("stack_trace", [
42 d.libDir("stack_trace", 'stack_trace ${current("stack_trace")}'), 42 d.libDir("stack_trace", 'stack_trace ${current("stack_trace")}'),
43 d.libPubspec("stack_trace", current("stack_trace")) 43 d.libPubspec("stack_trace", current("stack_trace"))
44 ]).create(); 44 ]).create();
45 45
46 d.dir(appPath, [ 46 d.dir(appPath, [
47 d.pubspec({ 47 d.pubspec({
48 "name": "myapp", 48 "name": "myapp",
49 "dependencies": {"barback": "any"}, 49 "dependencies": {"barback": "any"},
50 "dependency_overrides": { 50 "dependency_overrides": {
51 "stack_trace": {"path": "../stack_trace"}, 51 "stack_trace": {"path": "../stack_trace"},
52 } 52 }
53 }) 53 })
54 ]).create(); 54 ]).create();
55 55
56 pubCommand(command); 56 pubCommand(command);
57 57
58 // Validate that we're using the path dependency version of stack_trace 58 // Validate that we're using the path dependency version of stack_trace
59 // rather than the hosted version. 59 // rather than the hosted version.
60 d.packagesDir({ 60 d.packagesDir({
61 "stack_trace": current("stack_trace") 61 "stack_trace": current("stack_trace")
62 }).validate(); 62 }).validate();
63 }); 63 });
64 64
65 integration("doesn't add a constraint if barback isn't in the package " 65 integration("doesn't add a constraint if barback isn't in the package "
66 "graph", () { 66 "graph", () {
67 servePackages([ 67 servePackages((builder) {
68 packageMap("stack_trace", previous("stack_trace")), 68 builder.serve("stack_trace", previous("stack_trace"));
69 packageMap("stack_trace", current("stack_trace")), 69 builder.serve("stack_trace", current("stack_trace"));
70 packageMap("stack_trace", nextPatch("stack_trace")), 70 builder.serve("stack_trace", nextPatch("stack_trace"));
71 packageMap("stack_trace", max("stack_trace")), 71 builder.serve("stack_trace", max("stack_trace"));
72 packageMap("source_span", current("source_span")) 72 builder.serve("source_span", current("source_span"));
73 ]); 73 });
74 74
75 d.appDir({ 75 d.appDir({
76 "stack_trace": "any" 76 "stack_trace": "any"
77 }).create(); 77 }).create();
78 78
79 pubCommand(command); 79 pubCommand(command);
80 80
81 d.packagesDir({"stack_trace": max("stack_trace")}).validate(); 81 d.packagesDir({"stack_trace": max("stack_trace")}).validate();
82 }); 82 });
83 }); 83 });
84 84
85 integration("unlocks if the locked version doesn't meet pub's " 85 integration("unlocks if the locked version doesn't meet pub's "
86 "constraint", () { 86 "constraint", () {
87 servePackages([ 87 servePackages((builder) {
88 packageMap("barback", current("barback")), 88 builder.serve("barback", current("barback"));
89 packageMap("stack_trace", previous("stack_trace")), 89 builder.serve("stack_trace", previous("stack_trace"));
90 packageMap("stack_trace", current("stack_trace")), 90 builder.serve("stack_trace", current("stack_trace"));
91 packageMap("source_span", current("source_span")) 91 builder.serve("source_span", current("source_span"));
92 ]); 92 });
93 93
94 d.appDir({"barback": "any"}).create(); 94 d.appDir({"barback": "any"}).create();
95 95
96 // Hand-create a lockfile to pin the package to an older version. 96 // Hand-create a lockfile to pin the package to an older version.
97 createLockFile("myapp", hosted: { 97 createLockFile("myapp", hosted: {
98 "barback": current("barback"), 98 "barback": current("barback"),
99 "stack_trace": previous("stack_trace") 99 "stack_trace": previous("stack_trace")
100 }); 100 });
101 101
102 pubGet(); 102 pubGet();
(...skipping 12 matching lines...) Expand all
115 var constraint = barback.pubConstraints[packageName]; 115 var constraint = barback.pubConstraints[packageName];
116 return new Version(constraint.min.major, constraint.min.minor - 1, 0) 116 return new Version(constraint.min.major, constraint.min.minor - 1, 0)
117 .toString(); 117 .toString();
118 } 118 }
119 119
120 String nextPatch(String packageName) => 120 String nextPatch(String packageName) =>
121 barback.pubConstraints[packageName].min.nextPatch.toString(); 121 barback.pubConstraints[packageName].min.nextPatch.toString();
122 122
123 String max(String packageName) => 123 String max(String packageName) =>
124 barback.pubConstraints[packageName].max.toString(); 124 barback.pubConstraints[packageName].max.toString();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698