sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart - Issue 494943002: Don't load assets unnecessarily when precompiling executables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/get/dry_run_does_not_apply_changes_test.dart ('k') | sdk/lib/_internal/pub/test/get/hosted/cached_pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart

diff --git a/sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart b/sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart

index cd66d84ae35141b8d1fb7746958d3b8abb54ff66..27ccca322f117dc2a109bf203c0fe87be430db89 100644

--- a/sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart

+++ b/sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart

@@ -13,14 +13,14 @@ main() {

initConfig();

integration('only requests versions that are needed during solving', () {

- servePackages([

- packageMap("foo", "1.0.0"),

- packageMap("foo", "1.1.0"),

- packageMap("foo", "1.2.0"),

- packageMap("bar", "1.0.0"),

- packageMap("bar", "1.1.0"),

- packageMap("bar", "1.2.0")

- ]);

+ servePackages((builder) {

+ builder.serve("foo", "1.0.0");

+ builder.serve("foo", "1.1.0");

+ builder.serve("foo", "1.2.0");

+ builder.serve("bar", "1.0.0");

+ builder.serve("bar", "1.1.0");

+ builder.serve("bar", "1.2.0");

+ });

d.appDir({

"foo": "any"