sdk/lib/_internal/pub/lib/src/command/build.dart - Issue 494943002: Don't load assets unnecessarily when precompiling executables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/command/build.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart ('k') | sdk/lib/_internal/pub/lib/src/command/serve.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/command/build.dart

diff --git a/sdk/lib/_internal/pub/lib/src/command/build.dart b/sdk/lib/_internal/pub/lib/src/command/build.dart

index f086af1c1f6afea072d643705a32750c9df0cfa9..4b6ab0da3005938aa974abef5af1f1986f035850 100644

--- a/sdk/lib/_internal/pub/lib/src/command/build.dart

+++ b/sdk/lib/_internal/pub/lib/src/command/build.dart

@@ -52,8 +52,8 @@ class BuildCommand extends BarbackCommand {

// Since this server will only be hit by the transformer loader and isn't

// user-facing, just use an IPv4 address to avoid a weird bug on the

// OS X buildbots.

- return AssetEnvironment.create(entrypoint, mode, WatcherType.NONE,

- useDart2JS: true).then((environment) {

+ return AssetEnvironment.create(entrypoint, mode, useDart2JS: true)

+ .then((environment) {

// Show in-progress errors, but not results. Those get handled

// implicitly by getAllAssets().

environment.barback.errors.listen((error) {