sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart - Issue 494943002: Don't load assets unnecessarily when precompiling executables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart b/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

index 5e2c306f80d6130510f6f6b99d8e3a97081bfc27..36ec86594aac6f6093217fd7971613e8156d15dd 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

@@ -21,9 +21,10 @@ class PubPackageProvider implements PackageProvider {

final PackageGraph _graph;

final List<String> packages;

- PubPackageProvider(PackageGraph graph)

+ PubPackageProvider(PackageGraph graph, [Iterable<String> packages])

: _graph = graph,

- packages = [r"$pub", r"$sdk"]..addAll(graph.packages.keys);

+ packages = [r"$pub", r"$sdk"]

+ ..addAll(packages == null ? graph.packages.keys : packages);

Future<Asset> getAsset(AssetId id) {

// "$pub" is a psuedo-package that allows pub's transformer-loading

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »