sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart - Issue 494943002: Don't load assets unnecessarily when precompiling executables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_an_entrypoint_dependency_test.dart ('k') | sdk/lib/_internal/pub/test/snapshot/prints_errors_for_broken_snapshots_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart

diff --git a/sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart b/sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart

index 9b4512e7f9666be7ea99f86a86a4e129829e725a..039c7fb66fa7cfce09ad9a4319abbb2e6e7960a8 100644

--- a/sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart

+++ b/sdk/lib/_internal/pub/test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart

@@ -14,12 +14,12 @@ main() {

initConfig();

integration("doesn't create a snapshot for transitive dependencies' "

"executables", () {

- servePackages([

- packageMap("foo", "1.2.3", {'bar': '1.2.3'}),

- packageMap("bar", "1.2.3")

- ], contents: [

- d.dir("bin", [d.file("hello.dart", "void main() => print('hello!');")])

- ]);

+ servePackages((builder) {

+ builder.serve("foo", "1.2.3", deps: {'bar': '1.2.3'});

+ builder.serve("bar", "1.2.3", contents: [

+ d.dir("bin", [d.file("hello.dart", "void main() => print('hello!');")])

+ ]);

+ });

d.appDir({"foo": "1.2.3"}).create();