sdk/lib/_internal/pub/lib/src/executable.dart - Issue 494943002: Don't load assets unnecessarily when precompiling executables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/executable.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/entrypoint.dart ('k') | sdk/lib/_internal/pub/test/build/copies_non_dart_files_to_build_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/executable.dart

diff --git a/sdk/lib/_internal/pub/lib/src/executable.dart b/sdk/lib/_internal/pub/lib/src/executable.dart

index 2551bae81722e0be0e57305b2ad4d959cedd428c..5cecc13d63f4e5e2063353d2805c35e8f5d0f426 100644

--- a/sdk/lib/_internal/pub/lib/src/executable.dart

+++ b/sdk/lib/_internal/pub/lib/src/executable.dart

@@ -65,8 +65,10 @@ Future<int> runExecutable(PubCommand command, Entrypoint entrypoint,

}

var environment;

+ // TODO(nweiz): Use [packages] to only load assets from packages that the

+ // executable might load.

return AssetEnvironment.create(entrypoint, BarbackMode.RELEASE,

- WatcherType.NONE, useDart2JS: false).then((_environment) {

+ useDart2JS: false).then((_environment) {

environment = _environment;

environment.barback.errors.listen((error) {