Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 486213003: Move register conventions out of the IC classes. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move register conventions out of the IC classes. A change to a convention shouldn't require recompilation of ic.h/.cc. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23391

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -751 lines) Patch
M BUILD.gn View 1 2 5 chunks +5 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/debug-arm.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 24 chunks +54 lines, -49 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 5 chunks +17 lines, -13 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 5 chunks +16 lines, -15 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/debug-arm64.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 24 chunks +53 lines, -51 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 5 chunks +17 lines, -14 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 5 chunks +17 lines, -15 lines 0 comments Download
M src/code-stubs.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/code-stubs.cc View 1 2 5 chunks +21 lines, -19 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 5 chunks +14 lines, -18 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 4 chunks +14 lines, -14 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 24 chunks +55 lines, -53 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 5 chunks +10 lines, -8 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 16 chunks +38 lines, -60 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A src/ic/arm/ic-conventions-arm.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 5 chunks +10 lines, -8 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 16 chunks +37 lines, -57 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A src/ic/arm64/ic-conventions-arm64.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 2 chunks +7 lines, -6 lines 0 comments Download
A src/ic/ia32/ic-conventions-ia32.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 14 chunks +35 lines, -59 lines 0 comments Download
M src/ic/ic.h View 3 chunks +0 lines, -24 lines 0 comments Download
A src/ic/ic-conventions.h View 1 chunk +64 lines, -0 lines 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
A src/ic/x64/ic-conventions-x64.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 16 chunks +41 lines, -65 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/debug-x64.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 24 chunks +58 lines, -53 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 5 chunks +17 lines, -15 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 5 chunks +17 lines, -14 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Toon, PTAL for ia32, I'll upload ports after initial comment, thx! --Michael
6 years, 3 months ago (2014-08-25 17:20:46 UTC) #1
Toon Verwaest
lgtm
6 years, 3 months ago (2014-08-25 19:00:15 UTC) #2
mvstanton
Here are the ports. Submitting (whew).
6 years, 3 months ago (2014-08-26 09:08:05 UTC) #3
Toon Verwaest
lgtm
6 years, 3 months ago (2014-08-26 09:31:33 UTC) #4
mvstanton
6 years, 3 months ago (2014-08-26 09:50:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as 23391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698