Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 486213003: Move register conventions out of the IC classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 976 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 __ mov(ebx, 987 __ mov(ebx,
988 Operand(esi, Context::SlotOffset(Context::GLOBAL_OBJECT_INDEX))); 988 Operand(esi, Context::SlotOffset(Context::GLOBAL_OBJECT_INDEX)));
989 __ mov(ebx, FieldOperand(ebx, GlobalObject::kGlobalProxyOffset)); 989 __ mov(ebx, FieldOperand(ebx, GlobalObject::kGlobalProxyOffset));
990 990
991 // Push the receiver. 991 // Push the receiver.
992 __ bind(&push_receiver); 992 __ bind(&push_receiver);
993 __ push(ebx); 993 __ push(ebx);
994 994
995 // Copy all arguments from the array to the stack. 995 // Copy all arguments from the array to the stack.
996 Label entry, loop; 996 Label entry, loop;
997 Register receiver = LoadIC::ReceiverRegister(); 997 Register receiver = LoadConvention::ReceiverRegister();
998 Register key = LoadIC::NameRegister(); 998 Register key = LoadConvention::NameRegister();
999 __ mov(key, Operand(ebp, kIndexOffset)); 999 __ mov(key, Operand(ebp, kIndexOffset));
1000 __ jmp(&entry); 1000 __ jmp(&entry);
1001 __ bind(&loop); 1001 __ bind(&loop);
1002 __ mov(receiver, Operand(ebp, kArgumentsOffset)); // load arguments 1002 __ mov(receiver, Operand(ebp, kArgumentsOffset)); // load arguments
1003 1003
1004 // Use inline caching to speed up access to arguments. 1004 // Use inline caching to speed up access to arguments.
1005 if (FLAG_vector_ics) { 1005 if (FLAG_vector_ics) {
1006 __ mov(LoadIC::SlotRegister(), Immediate(Smi::FromInt(0))); 1006 __ mov(VectorLoadConvention::SlotRegister(), Immediate(Smi::FromInt(0)));
1007 } 1007 }
1008 Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Initialize(); 1008 Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Initialize();
1009 __ call(ic, RelocInfo::CODE_TARGET); 1009 __ call(ic, RelocInfo::CODE_TARGET);
1010 // It is important that we do not have a test instruction after the 1010 // It is important that we do not have a test instruction after the
1011 // call. A test instruction after the call is used to indicate that 1011 // call. A test instruction after the call is used to indicate that
1012 // we have generated an inline version of the keyed load. In this 1012 // we have generated an inline version of the keyed load. In this
1013 // case, we know that we are not generating a test instruction next. 1013 // case, we know that we are not generating a test instruction next.
1014 1014
1015 // Push the nth argument. 1015 // Push the nth argument.
1016 __ push(eax); 1016 __ push(eax);
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
1447 1447
1448 __ bind(&ok); 1448 __ bind(&ok);
1449 __ ret(0); 1449 __ ret(0);
1450 } 1450 }
1451 1451
1452 #undef __ 1452 #undef __
1453 } 1453 }
1454 } // namespace v8::internal 1454 } // namespace v8::internal
1455 1455
1456 #endif // V8_TARGET_ARCH_IA32 1456 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698