Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/code-stubs.cc

Issue 486213003: Move register conventions out of the IC classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 7506608d96e84fd60faa8e5913250a7908d207e5..d77f37ead2cef0615de00d3df14e4d5b3ad5dea5 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -581,10 +581,10 @@ void JSEntryStub::FinishCode(Handle<Code> code) {
void LoadFastElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { InterfaceDescriptor::ContextRegister(),
- LoadIC::ReceiverRegister(),
- LoadIC::NameRegister() };
- STATIC_ASSERT(LoadIC::kParameterCount == 2);
+ Register registers[] = {InterfaceDescriptor::ContextRegister(),
+ LoadConvention::ReceiverRegister(),
+ LoadConvention::NameRegister()};
+ STATIC_ASSERT(LoadConvention::kParameterCount == 2);
descriptor->Initialize(MajorKey(), arraysize(registers), registers,
FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
}
@@ -592,10 +592,10 @@ void LoadFastElementStub::InitializeInterfaceDescriptor(
void LoadDictionaryElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { InterfaceDescriptor::ContextRegister(),
- LoadIC::ReceiverRegister(),
- LoadIC::NameRegister() };
- STATIC_ASSERT(LoadIC::kParameterCount == 2);
+ Register registers[] = {InterfaceDescriptor::ContextRegister(),
+ LoadConvention::ReceiverRegister(),
+ LoadConvention::NameRegister()};
+ STATIC_ASSERT(LoadConvention::kParameterCount == 2);
descriptor->Initialize(MajorKey(), arraysize(registers), registers,
FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
}
@@ -603,10 +603,10 @@ void LoadDictionaryElementStub::InitializeInterfaceDescriptor(
void KeyedLoadGenericStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { InterfaceDescriptor::ContextRegister(),
- LoadIC::ReceiverRegister(),
- LoadIC::NameRegister() };
- STATIC_ASSERT(LoadIC::kParameterCount == 2);
+ Register registers[] = {InterfaceDescriptor::ContextRegister(),
+ LoadConvention::ReceiverRegister(),
+ LoadConvention::NameRegister()};
+ STATIC_ASSERT(LoadConvention::kParameterCount == 2);
descriptor->Initialize(
MajorKey(), arraysize(registers), registers,
Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry);
@@ -617,13 +617,15 @@ void HandlerStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
if (kind() == Code::LOAD_IC) {
Register registers[] = {InterfaceDescriptor::ContextRegister(),
- LoadIC::ReceiverRegister(), LoadIC::NameRegister()};
+ LoadConvention::ReceiverRegister(),
+ LoadConvention::NameRegister()};
descriptor->Initialize(MajorKey(), arraysize(registers), registers);
} else {
DCHECK_EQ(Code::STORE_IC, kind());
Register registers[] = {InterfaceDescriptor::ContextRegister(),
- StoreIC::ReceiverRegister(),
- StoreIC::NameRegister(), StoreIC::ValueRegister()};
+ StoreConvention::ReceiverRegister(),
+ StoreConvention::NameRegister(),
+ StoreConvention::ValueRegister()};
descriptor->Initialize(MajorKey(), arraysize(registers), registers,
FUNCTION_ADDR(StoreIC_MissFromStubFailure));
}
@@ -632,10 +634,10 @@ void HandlerStub::InitializeInterfaceDescriptor(
void StoreFastElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
- Register registers[] = { InterfaceDescriptor::ContextRegister(),
- KeyedStoreIC::ReceiverRegister(),
- KeyedStoreIC::NameRegister(),
- KeyedStoreIC::ValueRegister() };
+ Register registers[] = {InterfaceDescriptor::ContextRegister(),
+ StoreConvention::ReceiverRegister(),
+ StoreConvention::NameRegister(),
+ StoreConvention::ValueRegister()};
descriptor->Initialize(MajorKey(), arraysize(registers), registers,
FUNCTION_ADDR(KeyedStoreIC_MissFromStubFailure));
}
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698