Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: src/ic/ia32/ic-compiler-ia32.cc

Issue 486213003: Move register conventions out of the IC classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/ia32/ic-conventions-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ia32/ic-compiler-ia32.cc
diff --git a/src/ic/ia32/ic-compiler-ia32.cc b/src/ic/ia32/ic-compiler-ia32.cc
index 4fce7cc68fdb5c6a769155f06a6b9d58ca233402..7af370732d49a60c4fe0b3ae33406cd8352a9f9f 100644
--- a/src/ic/ia32/ic-compiler-ia32.cc
+++ b/src/ic/ia32/ic-compiler-ia32.cc
@@ -17,12 +17,13 @@ namespace internal {
void PropertyICCompiler::GenerateRuntimeSetProperty(MacroAssembler* masm,
StrictMode strict_mode) {
// Return address is on the stack.
- DCHECK(!ebx.is(StoreIC::ReceiverRegister()) &&
- !ebx.is(StoreIC::NameRegister()) && !ebx.is(StoreIC::ValueRegister()));
+ DCHECK(!ebx.is(StoreConvention::ReceiverRegister()) &&
+ !ebx.is(StoreConvention::NameRegister()) &&
+ !ebx.is(StoreConvention::ValueRegister()));
__ pop(ebx);
- __ push(StoreIC::ReceiverRegister());
- __ push(StoreIC::NameRegister());
- __ push(StoreIC::ValueRegister());
+ __ push(StoreConvention::ReceiverRegister());
+ __ push(StoreConvention::NameRegister());
+ __ push(StoreConvention::ValueRegister());
__ push(Immediate(Smi::FromInt(strict_mode)));
__ push(ebx); // return address
@@ -60,7 +61,7 @@ Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
// Polymorphic keyed stores may use the map register
Register map_reg = scratch1();
DCHECK(kind() != Code::KEYED_STORE_IC ||
- map_reg.is(KeyedStoreIC::MapRegister()));
+ map_reg.is(StoreConvention::MapRegister()));
__ mov(map_reg, FieldOperand(receiver(), HeapObject::kMapOffset));
int receiver_count = types->length();
int number_of_handled_maps = 0;
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/ia32/ic-conventions-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698