Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 486213003: Move register conventions out of the IC classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index 027517a835ce9b40b71a2b84362b19bcfa2669c9..82ea61c3e68ed00981d5d9a6e69bfedd21c5dac8 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -542,14 +542,10 @@ Handle<Code> CreateAllocationSiteStub::GenerateCode() {
template <>
HValue* CodeStubGraphBuilder<LoadFastElementStub>::BuildCodeStub() {
HInstruction* load = BuildUncheckedMonomorphicElementAccess(
- GetParameter(KeyedLoadIC::kReceiverIndex),
- GetParameter(KeyedLoadIC::kNameIndex),
- NULL,
- casted_stub()->is_js_array(),
- casted_stub()->elements_kind(),
- LOAD,
- NEVER_RETURN_HOLE,
- STANDARD_STORE);
+ GetParameter(LoadConvention::kReceiverIndex),
+ GetParameter(LoadConvention::kNameIndex), NULL,
+ casted_stub()->is_js_array(), casted_stub()->elements_kind(), LOAD,
+ NEVER_RETURN_HOLE, STANDARD_STORE);
return load;
}
@@ -661,11 +657,11 @@ Handle<Code> StringLengthStub::GenerateCode() {
template <>
HValue* CodeStubGraphBuilder<StoreFastElementStub>::BuildCodeStub() {
BuildUncheckedMonomorphicElementAccess(
- GetParameter(StoreIC::kReceiverIndex),
- GetParameter(StoreIC::kNameIndex),
- GetParameter(StoreIC::kValueIndex),
- casted_stub()->is_js_array(), casted_stub()->elements_kind(),
- STORE, NEVER_RETURN_HOLE, casted_stub()->store_mode());
+ GetParameter(StoreConvention::kReceiverIndex),
+ GetParameter(StoreConvention::kNameIndex),
+ GetParameter(StoreConvention::kValueIndex), casted_stub()->is_js_array(),
+ casted_stub()->elements_kind(), STORE, NEVER_RETURN_HOLE,
+ casted_stub()->store_mode());
return GetParameter(2);
}
@@ -1105,7 +1101,7 @@ HValue* CodeStubGraphBuilder<StoreGlobalStub>::BuildCodeInitializedStub() {
Handle<PropertyCell> placeholder_cell =
isolate()->factory()->NewPropertyCell(placeholer_value);
- HParameter* value = GetParameter(StoreIC::kValueIndex);
+ HParameter* value = GetParameter(StoreConvention::kValueIndex);
if (stub->check_global()) {
// Check that the map of the global has not changed: use a placeholder map
@@ -1451,8 +1447,8 @@ Handle<Code> FastNewContextStub::GenerateCode() {
template <>
HValue* CodeStubGraphBuilder<LoadDictionaryElementStub>::BuildCodeStub() {
- HValue* receiver = GetParameter(KeyedLoadIC::kReceiverIndex);
- HValue* key = GetParameter(KeyedLoadIC::kNameIndex);
+ HValue* receiver = GetParameter(LoadConvention::kReceiverIndex);
+ HValue* key = GetParameter(LoadConvention::kNameIndex);
Add<HCheckSmi>(key);
@@ -1572,8 +1568,8 @@ void CodeStubGraphBuilder<KeyedLoadGenericStub>::BuildExternalElementLoad(
HValue* CodeStubGraphBuilder<KeyedLoadGenericStub>::BuildCodeStub() {
- HValue* receiver = GetParameter(KeyedLoadIC::kReceiverIndex);
- HValue* key = GetParameter(KeyedLoadIC::kNameIndex);
+ HValue* receiver = GetParameter(LoadConvention::kReceiverIndex);
+ HValue* key = GetParameter(LoadConvention::kNameIndex);
// Split into a smi/integer case and unique string case.
HIfContinuation index_name_split_continuation(graph()->CreateBasicBlock(),
« no previous file with comments | « src/code-stubs.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698