Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 478483002: Remove code used by --disable-delegated-renderer on Mac (Closed)

Created:
6 years, 4 months ago by ccameron
Modified:
6 years, 4 months ago
Reviewers:
jbauman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, miu, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove code used by --disable-delegated-renderer on Mac BUG=314190 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290211

Patch Set 1 #

Patch Set 2 : Remove shaders as well #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3090 lines) Patch
M content/browser/renderer_host/compositing_iosurface_context_mac.h View 1 4 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_context_mac.mm View 1 4 chunks +2 lines, -31 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.h View 3 chunks +0 lines, -93 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 9 chunks +8 lines, -597 lines 0 comments Download
D content/browser/renderer_host/compositing_iosurface_shader_programs_mac.h View 1 1 chunk +0 lines, -81 lines 0 comments Download
D content/browser/renderer_host/compositing_iosurface_shader_programs_mac.cc View 1 1 chunk +0 lines, -448 lines 0 comments Download
D content/browser/renderer_host/compositing_iosurface_transformer_mac.h View 1 1 chunk +0 lines, -123 lines 0 comments Download
D content/browser/renderer_host/compositing_iosurface_transformer_mac.cc View 1 1 chunk +0 lines, -300 lines 0 comments Download
D content/browser/renderer_host/compositing_iosurface_transformer_mac_unittest.cc View 1 1 chunk +0 lines, -530 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 13 chunks +0 lines, -120 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 23 chunks +15 lines, -750 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
Satisfaction writing this CL approached that of cleaning a lint trap. There's still more stuff ...
6 years, 4 months ago (2014-08-14 21:22:50 UTC) #1
jbauman
lgtm
6 years, 4 months ago (2014-08-14 21:25:56 UTC) #2
ccameron
Btw, pulled out the shaders as well. Adding erikchen cause he noted that compiling shaders ...
6 years, 4 months ago (2014-08-14 21:59:33 UTC) #3
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-18 03:58:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/478483002/40001
6 years, 4 months ago (2014-08-18 03:59:56 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (40001) as 290211
6 years, 4 months ago (2014-08-18 05:37:42 UTC) #6
Mike West
6 years, 4 months ago (2014-08-18 06:40:13 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/472663004/ by mkwst@chromium.org.

The reason for reverting is: It looks like this broke layout tests on the mac
bots. See
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/...,
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/...,
and
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/....

Powered by Google App Engine
This is Rietveld 408576698