Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 477023002: Rename some crash related methods and improve debugging. (Closed)

Created:
6 years, 4 months ago by rvargas (doing something else)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename some crash related methods and improve debugging. Using a debugger with the thread watcher active is kind of a pain because it generates crashes that cannot be easily ignored after the fault. So generate a debug break instead of an access violation. Also, it is misleading to inspect crash dumps that have NullPointerCrash() on the stack when the code doesn't actually crash. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289866

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
rvargas (doing something else)
Hi Raman, I want to check in this change, but I'm afraid it will mess ...
6 years, 4 months ago (2014-08-15 00:15:42 UTC) #1
ramant (doing other things)
LGTM. Will make the change to chromecrash to support the new signatures after this CL ...
6 years, 4 months ago (2014-08-15 00:23:32 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 4 months ago (2014-08-15 00:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/477023002/1
6 years, 4 months ago (2014-08-15 00:32:47 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 15:22:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289866

Powered by Google App Engine
This is Rietveld 408576698