Sandbox: Make CreateRestrictedToken return a ScopedHandle.

Sandbox: Make CreateRestrictedToken return a ScopedHandle.

Removes raw handles from the API.

BUG=426577
TBR=garykac@chromium.org

Committed: https://crrev.com/9808175ad322e8387366cdec088e65ccb934ceac
Cr-Commit-Position: refs/heads/master@{#339130}

Committed: https://crrev.com/b2ad48e4fa7c866555c3fa71443cb2b9ddc7fd69
Cr-Commit-Position: refs/heads/master@{#339509}

[rvargas (doing something else), 2015-07-13 23:12:15]

rvargas@chromium.org changed reviewers:
+ wfh@chromium.org

[rvargas (doing something else), 2015-07-16 00:53:19]

On 2015/07/13 23:12:15, rvargas wrote:

ping

[Will Harris, 2015-07-16 03:23:12]

On 2015/07/16 00:53:19, rvargas wrote:
> On 2015/07/13 23:12:15, rvargas wrote:
> 
> ping

sorry must have slipped through. lgtm % nit

[Will Harris, 2015-07-16 03:23:56]

https://codereview.chromium.org/1232963002/diff/1/sandbox/win/src/restricted_...
File sandbox/win/src/restricted_token_utils.h (right):

https://codereview.chromium.org/1232963002/diff/1/sandbox/win/src/restricted_...
sandbox/win/src/restricted_token_utils.h:31: // token_handle is the output value
containing the handle of the
nit: update comment

[rvargas (doing something else), 2015-07-16 18:30:07]

thanks

https://codereview.chromium.org/1232963002/diff/1/sandbox/win/src/restricted_...
File sandbox/win/src/restricted_token_utils.h (right):

https://codereview.chromium.org/1232963002/diff/1/sandbox/win/src/restricted_...
sandbox/win/src/restricted_token_utils.h:31: // token_handle is the output value
containing the handle of the
On 2015/07/16 03:23:56, Will Harris wrote:
> nit: update comment

done. I also reordered the arguments to make the output last.

I have an itch to change the function to return the token and take an argument
for the error, but all these functions uniformly return DWORD :(...

[rvargas (doing something else), 2015-07-16 19:49:52]

The CQ bit was checked by rvargas@chromium.org

[rvargas (doing something else), 2015-07-16 19:49:52]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1232963002/#ps20001
(title: "Fix comment and reorder args")

[commit-bot: I haz the power, 2015-07-16 19:50:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232963002/20001

[commit-bot: I haz the power, 2015-07-16 21:42:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-16 21:43:24]

Patchset 2 (id:??) landed as
https://crrev.com/9808175ad322e8387366cdec088e65ccb934ceac
Cr-Commit-Position: refs/heads/master@{#339130}

[dcheng, 2015-07-16 22:10:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1231853005/ by dcheng@chromium.org.

The reason for reverting is: Broke the Win x64 debug build:
'GetRestrictedTokenHandle' : is not a member of 'sandbox::RestrictedToken'.

[Nico, 2015-07-16 22:10:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1240793004/ by thakis@chromium.org.

The reason for reverting is: Broke a bot:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28db....

[rvargas (doing something else), 2015-07-16 23:16:14]

rvargas@chromium.org changed reviewers:
+ garykac@chromium.org

[rvargas (doing something else), 2015-07-16 23:19:48]

On 2015/07/16 22:10:19, Nico wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1240793004/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: Broke a bot:
>
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28db....

+garykac

I missed that remoting is using low level sandbox files... got confused by some
functions implemented with the same name.

[rvargas (doing something else), 2015-07-20 19:34:53]

The CQ bit was checked by rvargas@chromium.org

[rvargas (doing something else), 2015-07-20 19:34:53]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1232963002/#ps40001
(title: "Fix remoting")

[commit-bot: I haz the power, 2015-07-20 19:35:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232963002/40001

[commit-bot: I haz the power, 2015-07-20 20:43:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-20 20:45:53]

Patchset 3 (id:??) landed as
https://crrev.com/b2ad48e4fa7c866555c3fa71443cb2b9ddc7fd69
Cr-Commit-Position: refs/heads/master@{#339509}