Sandbox: remove raw handles from SharedMemIPCServer::ServerControl

Sandbox: remove raw handles from SharedMemIPCServer::ServerControl

BUG=426577
Committed: https://crrev.com/b94b2e421bf8afe1691831e64ed3cb5043c05e16
Cr-Commit-Position: refs/heads/master@{#338139}

[rvargas (doing something else), 2015-07-08 23:58:14]

rvargas@chromium.org changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2015-07-09 16:51:53]

lgtm

https://codereview.chromium.org/1231673002/diff/1/sandbox/win/src/sharedmem_i...
File sandbox/win/src/sharedmem_ipc_server.cc (right):

https://codereview.chromium.org/1231673002/diff/1/sandbox/win/src/sharedmem_i...
sandbox/win/src/sharedmem_ipc_server.cc:395: }
maybe check() the return of set event?

[rvargas (doing something else), 2015-07-09 18:14:44]

thanks.

https://codereview.chromium.org/1231673002/diff/1/sandbox/win/src/sharedmem_i...
File sandbox/win/src/sharedmem_ipc_server.cc (right):

https://codereview.chromium.org/1231673002/diff/1/sandbox/win/src/sharedmem_i...
sandbox/win/src/sharedmem_ipc_server.cc:395: }
On 2015/07/09 16:51:53, cpu wrote:
> maybe check() the return of set event?

I'd prefer to keep this CL strictly as a refactor without functionality changes.

I can add the check on another CL if you want me to. Are you thinking that this
should only fail if the handle is being messed with, hence we should crash?

[rvargas (doing something else), 2015-07-09 19:33:38]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2015-07-09 19:36:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231673002/1

[commit-bot: I haz the power, 2015-07-09 20:58:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-09 21:00:35]

Patchset 1 (id:??) landed as
https://crrev.com/b94b2e421bf8afe1691831e64ed3cb5043c05e16
Cr-Commit-Position: refs/heads/master@{#338139}

[Nico, 2015-07-09 23:00:48]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-09 23:00:49]

Style plugin says:

In file included from ../../sandbox/win/src/handle_policy.cc:10:
In file included from ../..\sandbox/win/src/broker_services.h:18:
../..\sandbox/win/src/sharedmem_ipc_server.h(76,3) :  error: [chromium-style]
Complex class/struct needs an explicit out-of-line constructor.
  struct ServerControl {
  ^
../..\sandbox/win/src/sharedmem_ipc_server.h(76,3) :  error: [chromium-style]
Complex class/struct needs an explicit out-of-line destructor.
2 errors generated.