Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227163008: Sandbox: Make PolicyBase::MakeTokens return ScopedHandes (Closed)

Created:
5 years, 5 months ago by rvargas (doing something else)
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox: Make PolicyBase::MakeTokens return ScopedHandes Makes handle ownership a little cleaner. BUG=426577 Committed: https://crrev.com/c3c3b7ad436e9232ca6dbcd43c6c0ed682080993 Cr-Commit-Position: refs/heads/master@{#338363}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M sandbox/win/src/broker_services.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 5 chunks +16 lines, -11 lines 4 comments Download

Depends on Patchset:

Issue 477023002 Patch 1

Messages

Total messages: 9 (2 generated)
rvargas (doing something else)
5 years, 5 months ago (2015-07-09 23:19:58 UTC) #2
Will Harris
lgtm % optional nit https://codereview.chromium.org/1227163008/diff/1/sandbox/win/src/sandbox_policy_base.cc File sandbox/win/src/sandbox_policy_base.cc (right): https://codereview.chromium.org/1227163008/diff/1/sandbox/win/src/sandbox_policy_base.cc#newcode601 sandbox/win/src/sandbox_policy_base.cc:601: if (lowbox_sid_) { maybe DCHECK ...
5 years, 5 months ago (2015-07-10 18:11:31 UTC) #3
rvargas (doing something else)
Thanks https://codereview.chromium.org/1227163008/diff/1/sandbox/win/src/sandbox_policy_base.cc File sandbox/win/src/sandbox_policy_base.cc (right): https://codereview.chromium.org/1227163008/diff/1/sandbox/win/src/sandbox_policy_base.cc#newcode601 sandbox/win/src/sandbox_policy_base.cc:601: if (lowbox_sid_) { On 2015/07/10 18:11:31, Will Harris ...
5 years, 5 months ago (2015-07-10 18:31:56 UTC) #4
Will Harris
https://codereview.chromium.org/1227163008/diff/1/sandbox/win/src/sandbox_policy_base.cc File sandbox/win/src/sandbox_policy_base.cc (right): https://codereview.chromium.org/1227163008/diff/1/sandbox/win/src/sandbox_policy_base.cc#newcode601 sandbox/win/src/sandbox_policy_base.cc:601: if (lowbox_sid_) { On 2015/07/10 18:31:56, rvargas wrote: > ...
5 years, 5 months ago (2015-07-10 18:45:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227163008/1
5 years, 5 months ago (2015-07-10 21:17:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 21:25:48 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:26:55 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c3c3b7ad436e9232ca6dbcd43c6c0ed682080993
Cr-Commit-Position: refs/heads/master@{#338363}

Powered by Google App Engine
This is Rietveld 408576698