Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1228093004: Sandbox: Fix a violation to the syle plugin. (Closed)

Created:
5 years, 5 months ago by rvargas (doing something else)
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox: Fix a violation to the syle plugin. BUG=426577 R=thakis@chromium.org Committed: https://crrev.com/77c9ad9986492b1791139fe0dcc41fab00a40539 Cr-Commit-Position: refs/heads/master@{#338210}

Patch Set 1 #

Patch Set 2 : But wait, we'll also bundle a constructor for the same price #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M sandbox/win/src/sharedmem_ipc_server.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sandbox/win/src/sharedmem_ipc_server.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (2 generated)
rvargas (doing something else)
5 years, 5 months ago (2015-07-09 23:28:01 UTC) #1
Nico
Thanks! The message is ../..\sandbox/win/src/sharedmem_ipc_server.h(76,3) : error: [chromium-style] Complex class/struct needs an explicit out-of-line constructor. ...
5 years, 5 months ago (2015-07-09 23:54:29 UTC) #2
rvargas (doing something else)
updated. Thanks.
5 years, 5 months ago (2015-07-10 00:04:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228093004/20001
5 years, 5 months ago (2015-07-10 00:06:38 UTC) #6
Nico
Looks like the cq has a problem. I filed https://code.google.com/p/chromium/issues/detail?id=508783 for that and I'm going ...
5 years, 5 months ago (2015-07-10 02:35:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 02:36:22 UTC) #8
Nico
On 2015/07/10 02:36:22, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) Hm, ...
5 years, 5 months ago (2015-07-10 02:37:20 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 02:37:28 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77c9ad9986492b1791139fe0dcc41fab00a40539
Cr-Commit-Position: refs/heads/master@{#338210}

Powered by Google App Engine
This is Rietveld 408576698