Issue 1231673005: Sandbox: Update the constructor of TargetProcess to receive ScopedHandles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231673005: Sandbox: Update the constructor of TargetProcess to receive ScopedHandles. (Closed)

Created:
5 years, 5 months ago by rvargas (doing something else)

Modified:
5 years, 5 months ago

Reviewers:
Will Harris

CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Sandbox: Update the constructor of TargetProcess to receive ScopedHandles. Makes transfer of ownership explicit. BUG=426577 R=wfh@chromium.org Committed: https://crrev.com/d5483b5599969e98cd758e1b0a209fe60aa121bd Cr-Commit-Position: refs/heads/master@{#338333}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -8 lines)			Patch
M	sandbox/win/src/broker_services.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sandbox/win/src/target_process.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sandbox/win/src/target_process.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download

Depends on Patchset:

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231673005/1

5 years, 5 months ago (2015-07-10 19:17:58 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-10 19:24:31 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d5483b5599969e98cd758e1b0a209fe60aa121bd
Cr-Commit-Position: refs/heads/master@{#338333}