Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229163002: Sandbox: Remove raw handles from PolicyBase. (Closed)

Created:
5 years, 5 months ago by rvargas (doing something else)
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox: Remove raw handles from PolicyBase. Use ScopedHandle instead for owned HANDLEs. BUG=426577 Committed: https://crrev.com/dc89772f119d0043fd30f93789e81c0a59f8ab9a Cr-Commit-Position: refs/heads/master@{#338349}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M sandbox/win/src/broker_services.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 2 chunks +11 lines, -17 lines 2 comments Download

Depends on Patchset:

Issue 477023002 Patch 1

Messages

Total messages: 8 (2 generated)
rvargas (doing something else)
5 years, 5 months ago (2015-07-09 22:50:08 UTC) #2
Will Harris
lgtm https://codereview.chromium.org/1229163002/diff/1/sandbox/win/src/sandbox_policy_base.cc File sandbox/win/src/sandbox_policy_base.cc (right): https://codereview.chromium.org/1229163002/diff/1/sandbox/win/src/sandbox_policy_base.cc#newcode480 sandbox/win/src/sandbox_policy_base.cc:480: handles_to_share_.push_back(new base::win::ScopedHandle(duped_handle)); this is a behavior change, previously ...
5 years, 5 months ago (2015-07-10 18:05:02 UTC) #3
rvargas (doing something else)
thanks https://codereview.chromium.org/1229163002/diff/1/sandbox/win/src/sandbox_policy_base.cc File sandbox/win/src/sandbox_policy_base.cc (right): https://codereview.chromium.org/1229163002/diff/1/sandbox/win/src/sandbox_policy_base.cc#newcode480 sandbox/win/src/sandbox_policy_base.cc:480: handles_to_share_.push_back(new base::win::ScopedHandle(duped_handle)); On 2015/07/10 18:05:02, Will Harris wrote: ...
5 years, 5 months ago (2015-07-10 18:26:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229163002/1
5 years, 5 months ago (2015-07-10 19:57:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 20:42:48 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 20:44:43 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc89772f119d0043fd30f93789e81c0a59f8ab9a
Cr-Commit-Position: refs/heads/master@{#338349}

Powered by Google App Engine
This is Rietveld 408576698