Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472663004: Revert of Remove code used by --disable-delegated-renderer on Mac (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
Reviewers:
jbauman, ccameron
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, miu, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove code used by --disable-delegated-renderer on Mac (patchset #3 of https://codereview.chromium.org/478483002/) Reason for revert: It looks like this broke layout tests on the mac bots. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/10121, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/28815, and http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/31328. Original issue's description: > Remove code used by --disable-delegated-renderer on Mac > > BUG=314190 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290211 TBR=jbauman@chromium.org,ccameron@chromium.org NOTREECHECKS=true NOTRY=true BUG=314190 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3091 lines, -27 lines) Patch
M content/browser/renderer_host/compositing_iosurface_context_mac.h View 4 chunks +8 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_context_mac.mm View 4 chunks +31 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.h View 3 chunks +93 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 9 chunks +597 lines, -8 lines 0 comments Download
A content/browser/renderer_host/compositing_iosurface_shader_programs_mac.h View 1 chunk +81 lines, -0 lines 0 comments Download
A content/browser/renderer_host/compositing_iosurface_shader_programs_mac.cc View 1 chunk +448 lines, -0 lines 0 comments Download
A content/browser/renderer_host/compositing_iosurface_transformer_mac.h View 1 chunk +123 lines, -0 lines 0 comments Download
A content/browser/renderer_host/compositing_iosurface_transformer_mac.cc View 1 chunk +300 lines, -0 lines 0 comments Download
A content/browser/renderer_host/compositing_iosurface_transformer_mac_unittest.cc View 1 chunk +530 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 13 chunks +120 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 23 chunks +751 lines, -16 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Created Revert of Remove code used by --disable-delegated-renderer on Mac
6 years, 4 months ago (2014-08-18 06:40:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/472663004/1
6 years, 4 months ago (2014-08-18 06:40:42 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 06:41:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (1) as 290214

Powered by Google App Engine
This is Rietveld 408576698