Issue 44883004: [telemetry] Move tab from RunState to PageState.

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed)

Created:
7 years, 1 month ago by dtu

Modified:
7 years, 1 month ago

Reviewers:
Luigi Semenzato, tonyg, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Move tab from RunState to PageState. The idea is that "tab" is now "the tab for this particular page." Any references to it outside of the scope of an individual page are invalid. If you want an arbitrary tab for running JavaScript, use browser.tabs[0]. BUG=xvfb-run tools/telemetry/run_tests; tools/perf/run_tests TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231482

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Comment nit. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -72 lines)			Patch
M	tools/perf/benchmarks/dom_perf.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/measurements/endure.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/measurements/image_decoding.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/perf/measurements/memory.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/measurements/memory_multi_tab.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/perf/measurements/memory_pressure.py	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	tools/perf/measurements/page_cycler.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/perf/measurements/tab_switching.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/perf/metrics/io.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/perf/profile_creators/small_profile_creator.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_runner.py	View		10 chunks	+38 lines, -41 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_test.py	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/44883004/30001

7 years, 1 month ago (2013-10-26 04:18:29 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-10-26 04:30:17 UTC) #4

Luigi Semenzato

Just one minor nit. https://codereview.chromium.org/44883004/diff/30001/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/44883004/diff/30001/tools/telemetry/telemetry/page/page_test.py#newcode197 tools/telemetry/telemetry/page/page_test.py:197: create a new tab for ...

7 years, 1 month ago (2013-10-26 05:11:49 UTC) #6

dtu

https://codereview.chromium.org/44883004/diff/30001/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/44883004/diff/30001/tools/telemetry/telemetry/page/page_test.py#newcode197 tools/telemetry/telemetry/page/page_test.py:197: create a new tab for every page, return tab.browser.tabs.New().""" ...

7 years, 1 month ago (2013-10-28 19:26:55 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/44883004/260001

7 years, 1 month ago (2013-10-28 23:08:23 UTC) #8

Message was sent while issue was closed.

Change committed as 231482

Expand Messages | Collapse Messages