Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment nit. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 2213e0f0f02b00a980329e8735ebb38c604df94a..43f6d026ea3b2dc43a76e331b52e41773422151f 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -103,7 +103,7 @@ class PageTest(object):
def close_tabs_before_run(self, close_tabs):
self._close_tabs_before_run = close_tabs
- def NeedsBrowserRestartAfterEachRun(self, tab): # pylint: disable=W0613
+ def NeedsBrowserRestartAfterEachRun(self, browser): # pylint: disable=W0613
"""Override to specify browser restart after each run."""
return self._needs_browser_restart_after_each_run
@@ -138,22 +138,22 @@ class PageTest(object):
"""Override to customize if the test can be ran for the given page."""
return True
- def WillRunTest(self, tab):
+ def WillRunTest(self):
"""Override to do operations before the page set(s) are navigated."""
pass
- def DidRunTest(self, tab, results):
+ def DidRunTest(self, browser, results):
"""Override to do operations after all page set(s) are completed.
This will occur before the browser is torn down.
"""
pass
- def WillRunPageRepeats(self, page, tab):
+ def WillRunPageRepeats(self, page):
"""Override to do operations before each page is iterated over."""
pass
- def DidRunPageRepeats(self, page, tab):
+ def DidRunPageRepeats(self, page):
"""Override to do operations after each page is iterated over."""
pass
@@ -192,10 +192,10 @@ class PageTest(object):
any that may have been defined in the page set."""
return test_expectations.TestExpectations()
- def TabForPage(self, page, tab): # pylint: disable=W0613
+ def TabForPage(self, page, browser): # pylint: disable=W0613
"""Override to select a different tab for the page. For instance, to
- create a new tab for every page, return tab.browser.tabs.New()."""
- return tab
+ create a new tab for every page, return browser.tabs.New()."""
+ return browser.tabs[0]
def ValidatePageSet(self, page_set):
"""Override to examine the page set before the test run. Useful for
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698