tools/perf/benchmarks/dom_perf.py - Issue 44883004: [telemetry] Move tab from RunState to PageState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/dom_perf.py

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment nit. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/dom_perf.py

diff --git a/tools/perf/benchmarks/dom_perf.py b/tools/perf/benchmarks/dom_perf.py

index e2b74a2306336f1f335b2d0ed2bce7d878754cbe..ccafbd69f79e1aa071a3eed3d33fe1fb89c6253e 100644

--- a/tools/perf/benchmarks/dom_perf.py

+++ b/tools/perf/benchmarks/dom_perf.py

@@ -55,7 +55,7 @@ class DomPerfMeasurement(page_measurement.PageMeasurement):

finally:

tab.EvaluateJavaScript('document.cookie = "__domperf_finished=0"')

- def DidRunTest(self, tab, results):

+ def DidRunTest(self, browser, results):

# Now give the geometric mean as the total for the combined runs.

scores = []

for result in results.page_results:

« no previous file with comments | « no previous file | tools/perf/measurements/endure.py » ('j') | no next file with comments »