tools/perf/measurements/page_cycler.py - Issue 44883004: [telemetry] Move tab from RunState to PageState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment nit. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index 873a8295a7d34d8cb80b75c080bf50ad74baf436..018c1e56615d3382220596046532d4c66cb98f30 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -173,9 +173,9 @@ class PageCycler(page_measurement.PageMeasurement):

self._speedindex_metric.AddResults(

tab, results, chart_name=chart_name_prefix+'speed_index')

- def DidRunTest(self, tab, results):

+ def DidRunTest(self, browser, results):

self._memory_metric.AddSummaryResults(results)

- io.IOMetric().AddSummaryResults(tab, results)

+ io.IOMetric().AddSummaryResults(browser, results)

def ShouldRunCold(self, url):

# We do the warm runs first for two reasons. The first is so we can

« no previous file with comments | « tools/perf/measurements/memory_pressure.py ('k') | tools/perf/measurements/tab_switching.py » ('j') | no next file with comments »