Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Side by Side Diff: tools/perf/metrics/io.py

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment nit. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import Metric 5 from metrics import Metric
6 6
7 class IOMetric(Metric): 7 class IOMetric(Metric):
8 """IO-related metrics, obtained via telemetry.core.Browser.""" 8 """IO-related metrics, obtained via telemetry.core.Browser."""
9 9
10 @classmethod 10 @classmethod
11 def CustomizeBrowserOptions(cls, options): 11 def CustomizeBrowserOptions(cls, options):
12 options.AppendExtraBrowserArgs('--no-sandbox') 12 options.AppendExtraBrowserArgs('--no-sandbox')
13 13
14 def Start(self, page, tab): 14 def Start(self, page, tab):
15 raise NotImplementedError() 15 raise NotImplementedError()
16 16
17 def Stop(self, page, tab): 17 def Stop(self, page, tab):
18 raise NotImplementedError() 18 raise NotImplementedError()
19 19
20 def AddResults(self, tab, results): 20 def AddResults(self, tab, results):
21 # This metric currently only returns summary results, not per-page results. 21 # This metric currently only returns summary results, not per-page results.
22 raise NotImplementedError() 22 raise NotImplementedError()
23 23
24 def AddSummaryResults(self, tab, results): 24 def AddSummaryResults(self, browser, results):
25 """Add summary results to the results object.""" 25 """Add summary results to the results object."""
26 io_stats = tab.browser.io_stats 26 io_stats = browser.io_stats
27 if not io_stats['Browser']: 27 if not io_stats['Browser']:
28 return 28 return
29 29
30 def AddSummariesForProcessType(process_type_io, process_type_trace): 30 def AddSummariesForProcessType(process_type_io, process_type_trace):
31 """For a given process type, add all relevant summary results. 31 """For a given process type, add all relevant summary results.
32 32
33 Args: 33 Args:
34 process_type_io: Type of process (eg Browser or Renderer). 34 process_type_io: Type of process (eg Browser or Renderer).
35 process_type_trace: String to be added to the trace name in the results. 35 process_type_trace: String to be added to the trace name in the results.
36 """ 36 """
(...skipping 15 matching lines...) Expand all
52 if 'WriteTransferCount' in io_stats[process_type_io]: 52 if 'WriteTransferCount' in io_stats[process_type_io]:
53 results.AddSummary('write_bytes_' + process_type_trace, 'kb', 53 results.AddSummary('write_bytes_' + process_type_trace, 'kb',
54 io_stats[process_type_io] 54 io_stats[process_type_io]
55 ['WriteTransferCount'] / 1024, 55 ['WriteTransferCount'] / 1024,
56 data_type='unimportant') 56 data_type='unimportant')
57 57
58 AddSummariesForProcessType('Browser', 'browser') 58 AddSummariesForProcessType('Browser', 'browser')
59 AddSummariesForProcessType('Renderer', 'renderer') 59 AddSummariesForProcessType('Renderer', 'renderer')
60 AddSummariesForProcessType('Gpu', 'gpu') 60 AddSummariesForProcessType('Gpu', 'gpu')
61 61
OLDNEW
« no previous file with comments | « tools/perf/measurements/tab_switching.py ('k') | tools/perf/profile_creators/small_profile_creator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698