tools/perf/measurements/image_decoding.py - Issue 44883004: [telemetry] Move tab from RunState to PageState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/image_decoding.py

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment nit. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/image_decoding.py

diff --git a/tools/perf/measurements/image_decoding.py b/tools/perf/measurements/image_decoding.py

index e838bfbf887a31a0f244136a6579a47e9e3e7332..7207891a5166ddb4e794dca0a4d5ae5fbb2c34cd 100644

--- a/tools/perf/measurements/image_decoding.py

+++ b/tools/perf/measurements/image_decoding.py

@@ -19,8 +19,8 @@ class ImageDecoding(page_measurement.PageMeasurement):

""")

tab.StartTimelineRecording()

- def NeedsBrowserRestartAfterEachRun(self, tab):

- return not tab.ExecuteJavaScript("""

+ def NeedsBrowserRestartAfterEachRun(self, browser):

+ return not browser.tabs[0].ExecuteJavaScript("""

window.chrome &&

chrome.gpuBenchmarking &&

chrome.gpuBenchmarking.clearImageCache;

« no previous file with comments | « tools/perf/measurements/endure.py ('k') | tools/perf/measurements/memory.py » ('j') | no next file with comments »