Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tools/perf/measurements/memory_pressure.py

Issue 44883004: [telemetry] Move tab from RunState to PageState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment nit. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/memory_multi_tab.py ('k') | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/memory_pressure.py
diff --git a/tools/perf/measurements/memory_pressure.py b/tools/perf/measurements/memory_pressure.py
index 05dc1f4bbe190a7bebfbfa85622fae09b3128937..92ee334f028e869148a8339750e13ba4207d1e36 100644
--- a/tools/perf/measurements/memory_pressure.py
+++ b/tools/perf/measurements/memory_pressure.py
@@ -13,6 +13,7 @@ import logging
from metrics import histogram_util
from telemetry.page import page_measurement
+
class MemoryPressure(page_measurement.PageMeasurement):
def __init__(self, *args, **kwargs):
super(MemoryPressure, self).__init__(*args, **kwargs)
@@ -25,8 +26,8 @@ class MemoryPressure(page_measurement.PageMeasurement):
histogram_util.CustomizeBrowserOptions(options)
# Open a new tab at each page
- def TabForPage(self, page, tab):
- return tab.browser.tabs.New()
+ def TabForPage(self, page, browser):
+ return browser.tabs.New()
def GetTabsHistogramCounts(self, tab):
histogram_type = histogram_util.BROWSER_HISTOGRAM
@@ -36,7 +37,7 @@ class MemoryPressure(page_measurement.PageMeasurement):
histogram_type, "Tabs.SadTab.KillCreated", tab)
return (discard_count, kill_count)
- def DidRunPageRepeats(self, page, tab):
+ def MeasurePage(self, page, tab, results):
# After navigating to each page, check if it triggered tab discards or
# kills.
(discard_count, kill_count) = self.GetTabsHistogramCounts(tab)
@@ -54,6 +55,3 @@ class MemoryPressure(page_measurement.PageMeasurement):
logging.info("test ending at tab %d, discards = %d, kills = %d" %
(self._tab_count, discard_count, kill_count))
self.RequestExit()
-
- def MeasurePage(self, page, tab, results): # pylint: disable=W0613
- pass
« no previous file with comments | « tools/perf/measurements/memory_multi_tab.py ('k') | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698