Make DrawQuad constructors public, rm DQ::Create() function

Make DrawQuad constructors public, rm DQ::Create() function

In order to let RenderPass control allocation of DrawQuads, public DQ
constructors, and make all use of DQ::Create function to make_scoped_ptr
of public constructors.

Similar to 271683004, and follow 380893004.

BUG=344962
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283389

[weiliangc, 2014-07-15 18:09:56]

cc: danakj
mojo: jamesr
cc_messages: kenrb

[jamesr, 2014-07-15 18:14:47]

lgtm

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
File mojo/services/public/cpp/surfaces/tests/surface_unittest.cc (right):

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
mojo/services/public/cpp/surfaces/tests/surface_unittest.cc:100:
scoped_ptr<cc::SurfaceDrawQuad> surface_quad =
you can simplify this and the other construction ones to just

scoped_ptr<ThingyQuad> quad(new ThingyQuad);

and get rid of the make_scoped_ptr

[danakj, 2014-07-15 18:15:00]

LGTM

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
File mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc (right):

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc:112:
scoped_ptr<cc::DrawQuad> ConvertTo(const surfaces::QuadPtr& input,
In the near future this is going to need a RenderPass* to attach the DrawQuad
to.

[weiliangc, 2014-07-15 18:28:12]

Get rid of make_scoped_ptr.

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
File mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc (right):

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc:112:
scoped_ptr<cc::DrawQuad> ConvertTo(const surfaces::QuadPtr& input,
On 2014/07/15 18:15:00, danakj wrote:
> In the near future this is going to need a RenderPass* to attach the DrawQuad
> to.

Coming up in next CL, nothing but fixing this file. :3

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
File mojo/services/public/cpp/surfaces/tests/surface_unittest.cc (right):

https://codereview.chromium.org/398533002/diff/20001/mojo/services/public/cpp...
mojo/services/public/cpp/surfaces/tests/surface_unittest.cc:100:
scoped_ptr<cc::SurfaceDrawQuad> surface_quad =
On 2014/07/15 18:14:47, jamesr wrote:
> you can simplify this and the other construction ones to just
> 
> scoped_ptr<ThingyQuad> quad(new ThingyQuad);
> 
> and get rid of the make_scoped_ptr

Done.

[danakj, 2014-07-15 18:29:14]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-07-15 18:33:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/398533002/40001

[kenrb, 2014-07-15 19:10:30]

ipc lgtm

[commit-bot: I haz the power, 2014-07-16 03:02:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-16 03:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 03:18:19]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[danakj, 2014-07-16 06:02:39]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-07-16 06:07:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/398533002/40001

[commit-bot: I haz the power, 2014-07-16 07:51:57]

Change committed as 283389