Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: cc/quads/render_pass_draw_quad.cc

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/render_pass_draw_quad.h ('k') | cc/quads/render_pass_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/render_pass_draw_quad.h" 5 #include "cc/quads/render_pass_draw_quad.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "cc/base/math_util.h" 8 #include "cc/base/math_util.h"
9 #include "cc/debug/traced_value.h" 9 #include "cc/debug/traced_value.h"
10 #include "third_party/skia/include/core/SkImageFilter.h" 10 #include "third_party/skia/include/core/SkImageFilter.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 RenderPassDrawQuad::RenderPassDrawQuad() 14 RenderPassDrawQuad::RenderPassDrawQuad()
15 : render_pass_id(RenderPass::Id(-1, -1)), 15 : render_pass_id(RenderPass::Id(-1, -1)),
16 is_replica(false), 16 is_replica(false),
17 mask_resource_id(static_cast<ResourceProvider::ResourceId>(-1)) { 17 mask_resource_id(static_cast<ResourceProvider::ResourceId>(-1)) {
18 } 18 }
19 19
20 RenderPassDrawQuad::~RenderPassDrawQuad() { 20 RenderPassDrawQuad::~RenderPassDrawQuad() {
21 } 21 }
22 22
23 scoped_ptr<RenderPassDrawQuad> RenderPassDrawQuad::Create() {
24 return make_scoped_ptr(new RenderPassDrawQuad);
25 }
26
27 void RenderPassDrawQuad::SetNew( 23 void RenderPassDrawQuad::SetNew(
28 const SharedQuadState* shared_quad_state, 24 const SharedQuadState* shared_quad_state,
29 const gfx::Rect& rect, 25 const gfx::Rect& rect,
30 const gfx::Rect& visible_rect, 26 const gfx::Rect& visible_rect,
31 RenderPass::Id render_pass_id, 27 RenderPass::Id render_pass_id,
32 bool is_replica, 28 bool is_replica,
33 ResourceProvider::ResourceId mask_resource_id, 29 ResourceProvider::ResourceId mask_resource_id,
34 const gfx::Rect& contents_changed_since_last_frame, 30 const gfx::Rect& contents_changed_since_last_frame,
35 const gfx::RectF& mask_uv_rect, 31 const gfx::RectF& mask_uv_rect,
36 const FilterOperations& filters, 32 const FilterOperations& filters,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 value->SetBoolean("is_replica", is_replica); 87 value->SetBoolean("is_replica", is_replica);
92 value->SetInteger("mask_resource_id", mask_resource_id); 88 value->SetInteger("mask_resource_id", mask_resource_id);
93 value->Set("contents_changed_since_last_frame", 89 value->Set("contents_changed_since_last_frame",
94 MathUtil::AsValue(contents_changed_since_last_frame).release()); 90 MathUtil::AsValue(contents_changed_since_last_frame).release());
95 value->Set("mask_uv_rect", MathUtil::AsValue(mask_uv_rect).release()); 91 value->Set("mask_uv_rect", MathUtil::AsValue(mask_uv_rect).release());
96 value->Set("filters", filters.AsValue().release()); 92 value->Set("filters", filters.AsValue().release());
97 value->Set("background_filters", background_filters.AsValue().release()); 93 value->Set("background_filters", background_filters.AsValue().release());
98 } 94 }
99 95
100 } // namespace cc 96 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/render_pass_draw_quad.h ('k') | cc/quads/render_pass_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698