Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: cc/quads/solid_color_draw_quad.cc

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/solid_color_draw_quad.h ('k') | cc/quads/stream_video_draw_quad.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/solid_color_draw_quad.h" 5 #include "cc/quads/solid_color_draw_quad.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 namespace cc { 10 namespace cc {
11 11
12 SolidColorDrawQuad::SolidColorDrawQuad() 12 SolidColorDrawQuad::SolidColorDrawQuad()
13 : color(0), force_anti_aliasing_off(false) {} 13 : color(0), force_anti_aliasing_off(false) {}
14 14
15 scoped_ptr<SolidColorDrawQuad> SolidColorDrawQuad::Create() {
16 return make_scoped_ptr(new SolidColorDrawQuad);
17 }
18
19 void SolidColorDrawQuad::SetNew(const SharedQuadState* shared_quad_state, 15 void SolidColorDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
20 const gfx::Rect& rect, 16 const gfx::Rect& rect,
21 const gfx::Rect& visible_rect, 17 const gfx::Rect& visible_rect,
22 SkColor color, 18 SkColor color,
23 bool force_anti_aliasing_off) { 19 bool force_anti_aliasing_off) {
24 gfx::Rect opaque_rect = SkColorGetA(color) == 255 ? rect : gfx::Rect(); 20 gfx::Rect opaque_rect = SkColorGetA(color) == 255 ? rect : gfx::Rect();
25 bool needs_blending = false; 21 bool needs_blending = false;
26 DrawQuad::SetAll(shared_quad_state, DrawQuad::SOLID_COLOR, rect, opaque_rect, 22 DrawQuad::SetAll(shared_quad_state, DrawQuad::SOLID_COLOR, rect, opaque_rect,
27 visible_rect, needs_blending); 23 visible_rect, needs_blending);
28 this->color = color; 24 this->color = color;
(...skipping 21 matching lines...) Expand all
50 DCHECK(quad->material == DrawQuad::SOLID_COLOR); 46 DCHECK(quad->material == DrawQuad::SOLID_COLOR);
51 return static_cast<const SolidColorDrawQuad*>(quad); 47 return static_cast<const SolidColorDrawQuad*>(quad);
52 } 48 }
53 49
54 void SolidColorDrawQuad::ExtendValue(base::DictionaryValue* value) const { 50 void SolidColorDrawQuad::ExtendValue(base::DictionaryValue* value) const {
55 value->SetInteger("color", color); 51 value->SetInteger("color", color);
56 value->SetBoolean("force_anti_aliasing_off", force_anti_aliasing_off); 52 value->SetBoolean("force_anti_aliasing_off", force_anti_aliasing_off);
57 } 53 }
58 54
59 } // namespace cc 55 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/solid_color_draw_quad.h ('k') | cc/quads/stream_video_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698