Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: cc/quads/render_pass_unittest.cc

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/render_pass_draw_quad.cc ('k') | cc/quads/solid_color_draw_quad.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/render_pass.h" 5 #include "cc/quads/render_pass.h"
6 6
7 #include "cc/base/math_util.h" 7 #include "cc/base/math_util.h"
8 #include "cc/base/scoped_ptr_vector.h" 8 #include "cc/base/scoped_ptr_vector.h"
9 #include "cc/output/copy_output_request.h" 9 #include "cc/output/copy_output_request.h"
10 #include "cc/quads/checkerboard_draw_quad.h" 10 #include "cc/quads/checkerboard_draw_quad.h"
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 0); 205 0);
206 206
207 CheckerboardDrawQuad* contrib_quad = 207 CheckerboardDrawQuad* contrib_quad =
208 contrib->CreateAndAppendDrawQuad<CheckerboardDrawQuad>(); 208 contrib->CreateAndAppendDrawQuad<CheckerboardDrawQuad>();
209 contrib_quad->SetNew(contrib->shared_quad_state_list.back(), 209 contrib_quad->SetNew(contrib->shared_quad_state_list.back(),
210 gfx::Rect(3, 3, 3, 3), 210 gfx::Rect(3, 3, 3, 3),
211 gfx::Rect(3, 3, 3, 3), 211 gfx::Rect(3, 3, 3, 3),
212 SkColor()); 212 SkColor());
213 213
214 // And a RenderPassDrawQuad for the contributing pass. 214 // And a RenderPassDrawQuad for the contributing pass.
215 scoped_ptr<RenderPassDrawQuad> pass_quad = RenderPassDrawQuad::Create(); 215 scoped_ptr<RenderPassDrawQuad> pass_quad =
216 make_scoped_ptr(new RenderPassDrawQuad);
216 pass_quad->SetNew(pass->shared_quad_state_list.back(), 217 pass_quad->SetNew(pass->shared_quad_state_list.back(),
217 contrib_output_rect, 218 contrib_output_rect,
218 contrib_output_rect, 219 contrib_output_rect,
219 contrib_id, 220 contrib_id,
220 false, // is_replica 221 false, // is_replica
221 0, // mask_resource_id 222 0, // mask_resource_id
222 contrib_damage_rect, 223 contrib_damage_rect,
223 gfx::RectF(), // mask_uv_rect 224 gfx::RectF(), // mask_uv_rect
224 FilterOperations(), 225 FilterOperations(),
225 FilterOperations()); 226 FilterOperations());
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 314
314 // Make a copy with CopyAll(). 315 // Make a copy with CopyAll().
315 RenderPassList copy_list; 316 RenderPassList copy_list;
316 RenderPass::CopyAll(pass_list, &copy_list); 317 RenderPass::CopyAll(pass_list, &copy_list);
317 318
318 CompareRenderPassLists(pass_list, copy_list); 319 CompareRenderPassLists(pass_list, copy_list);
319 } 320 }
320 321
321 } // namespace 322 } // namespace
322 } // namespace cc 323 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/render_pass_draw_quad.cc ('k') | cc/quads/solid_color_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698