cc/quads/solid_color_draw_quad.h - Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/solid_color_draw_quad.h

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/solid_color_draw_quad.h

diff --git a/cc/quads/solid_color_draw_quad.h b/cc/quads/solid_color_draw_quad.h

index 4b8b9a3ae1b1a8a8d457e60b650880e31b191e03..1e746e0ae98ba6658d526c5a68db8d46262bf172 100644

--- a/cc/quads/solid_color_draw_quad.h

+++ b/cc/quads/solid_color_draw_quad.h

@@ -14,7 +14,7 @@ namespace cc {

class CC_EXPORT SolidColorDrawQuad : public DrawQuad {

public:

- static scoped_ptr<SolidColorDrawQuad> Create();

+ SolidColorDrawQuad();

void SetNew(const SharedQuadState* shared_quad_state,

const gfx::Rect& rect,

@@ -39,7 +39,6 @@ class CC_EXPORT SolidColorDrawQuad : public DrawQuad {

static const SolidColorDrawQuad* MaterialCast(const DrawQuad*);

private:

- SolidColorDrawQuad();

virtual void ExtendValue(base::DictionaryValue* value) const OVERRIDE;

};

« no previous file with comments | « cc/quads/render_pass_unittest.cc ('k') | cc/quads/solid_color_draw_quad.cc » ('j') | no next file with comments »