content/common/cc_messages.cc - Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/cc_messages.cc

Issue 398533002: Make DrawQuad constructors public, rm DQ::Create() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: get rid of make_scoped_ptr Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/cc_messages.cc

diff --git a/content/common/cc_messages.cc b/content/common/cc_messages.cc

index 4750061bbcff65fc531d3d0ad15fd4f40f3dfff2..1e2d7419b3bb2b41708a6669b1f19d24ed37ac26 100644

--- a/content/common/cc_messages.cc

+++ b/content/common/cc_messages.cc

@@ -395,7 +395,7 @@ static size_t ReserveSizeForRenderPassWrite(const cc::RenderPass& p) {

template<typename QuadType>

static scoped_ptr<cc::DrawQuad> ReadDrawQuad(const Message* m,

PickleIterator* iter) {

- scoped_ptr<QuadType> quad = QuadType::Create();

+ scoped_ptr<QuadType> quad(new QuadType);

if (!ReadParam(m, iter, quad.get()))

return scoped_ptr<QuadType>().template PassAs<cc::DrawQuad>();

return quad.template PassAs<cc::DrawQuad>();

« no previous file with comments | « cc/quads/yuv_video_draw_quad.cc ('k') | mojo/examples/surfaces_app/child_impl.cc » ('j') | no next file with comments »