Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed)

Created:
6 years, 5 months ago by Bernhard Bauer
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, browser-components-watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, dconnelly
Visibility:
Public.

Description

Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. BUG=393149 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284958

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 8

Patch Set 3 : review #

Patch Set 4 : comments #

Patch Set 5 : . #

Patch Set 6 : sync #

Patch Set 7 : fix #

Patch Set 8 : fix #

Patch Set 9 : fix #

Patch Set 10 : revert unnecessary changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -108 lines) Patch
M chrome/browser/history/delete_directive_handler.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 2 3 4 5 6 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 3 4 4 chunks +26 lines, -17 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_db_task.h View 1 2 3 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 2 3 chunks +21 lines, -12 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_impl_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 2 3 4 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +34 lines, -20 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 1 2 3 4 5 chunks +20 lines, -7 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 2 3 4 5 6 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Bernhard Bauer
Please review.
6 years, 5 months ago (2014-07-14 09:30:09 UTC) #1
sky
https://codereview.chromium.org/387923002/diff/20001/chrome/browser/history/history_backend.cc File chrome/browser/history/history_backend.cc (right): https://codereview.chromium.org/387923002/diff/20001/chrome/browser/history/history_backend.cc#newcode178 chrome/browser/history/history_backend.cc:178: origin_loop_->PostTask( Document why this is done. https://codereview.chromium.org/387923002/diff/20001/chrome/browser/history/history_backend.cc#newcode219 chrome/browser/history/history_backend.cc:219: STLDeleteContainerPointers(queued_history_db_tasks_.begin(), ...
6 years, 5 months ago (2014-07-14 20:27:44 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/387923002/diff/20001/chrome/browser/history/history_backend.cc File chrome/browser/history/history_backend.cc (right): https://codereview.chromium.org/387923002/diff/20001/chrome/browser/history/history_backend.cc#newcode178 chrome/browser/history/history_backend.cc:178: origin_loop_->PostTask( On 2014/07/14 20:27:44, sky wrote: > Document why ...
6 years, 5 months ago (2014-07-15 10:17:25 UTC) #3
sky
LGTM
6 years, 5 months ago (2014-07-15 16:37:18 UTC) #4
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-17 15:02:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/387923002/100001
6 years, 5 months ago (2014-07-17 15:03:28 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 16:54:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 17:04:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/161952) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/207442) linux_chromium_chromeos_clang_dbg ...
6 years, 5 months ago (2014-07-17 17:04:38 UTC) #9
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-23 08:37:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/387923002/160001
6 years, 5 months ago (2014-07-23 08:38:40 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 10:52:13 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 10:55:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81727)
6 years, 5 months ago (2014-07-23 10:55:47 UTC) #14
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-23 11:48:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/387923002/180001
6 years, 5 months ago (2014-07-23 11:49:15 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 16:53:48 UTC) #17
Message was sent while issue was closed. 
Change committed as 284958

Powered by Google App Engine
This is Rietveld 408576698