chrome/browser/history/history_service.h - Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service.h

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert unnecessary changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_service.h

diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h

index 76cd07d91da3283dd5e3a8bde8edbd176a8d1ca1..6cb5aeeeedba55bcadf5d4f303d6dc9e244d6384 100644

--- a/chrome/browser/history/history_service.h

+++ b/chrome/browser/history/history_service.h

@@ -443,8 +443,8 @@ class HistoryService : public CancelableRequestProvider,

// Generic Stuff -------------------------------------------------------------

// Schedules a HistoryDBTask for running on the history backend thread. See

- // HistoryDBTask for details on what this does.

- virtual void ScheduleDBTask(scoped_refptr<history::HistoryDBTask> task,

+ // HistoryDBTask for details on what this does. Takes ownership of |task|.

+ virtual void ScheduleDBTask(scoped_ptr<history::HistoryDBTask> task,

base::CancelableTaskTracker* tracker);

// Adds or removes observers for the VisitDatabase.

« no previous file with comments | « chrome/browser/history/history_db_task.h ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »