chrome/browser/ui/sync/profile_signin_confirmation_helper.cc - Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert unnecessary changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/instant_extended_interactive_uitest.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

index 9585fb97b11e7a046013018615e1ac8aa9b7a8e5..8b7ffd7ec2c53f2448e96c36d35d4bd19d407756 100644

--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

@@ -155,9 +155,9 @@ void ProfileSigninConfirmationHelper::CheckHasTypedURLs() {

return;

}

service->ScheduleDBTask(

- new HasTypedURLsTask(

+ scoped_ptr<history::HistoryDBTask>(new HasTypedURLsTask(

base::Bind(&ProfileSigninConfirmationHelper::ReturnResult,

- base::Unretained(this))),

+ base::Unretained(this)))),

&task_tracker_);

}