Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/browser/history/history_service.h

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 const base::string16& term); 436 const base::string16& term);
437 437
438 // Bookmarks ----------------------------------------------------------------- 438 // Bookmarks -----------------------------------------------------------------
439 439
440 // Notification that a URL is no longer bookmarked. 440 // Notification that a URL is no longer bookmarked.
441 void URLsNoLongerBookmarked(const std::set<GURL>& urls); 441 void URLsNoLongerBookmarked(const std::set<GURL>& urls);
442 442
443 // Generic Stuff ------------------------------------------------------------- 443 // Generic Stuff -------------------------------------------------------------
444 444
445 // Schedules a HistoryDBTask for running on the history backend thread. See 445 // Schedules a HistoryDBTask for running on the history backend thread. See
446 // HistoryDBTask for details on what this does. 446 // HistoryDBTask for details on what this does. Takes ownership of |task|.
447 virtual void ScheduleDBTask(scoped_refptr<history::HistoryDBTask> task, 447 virtual void ScheduleDBTask(history::HistoryDBTask* task,
sky 2014/07/14 20:27:44 Make take a scoped_ptr.
Bernhard Bauer 2014/07/15 10:17:24 Done.
448 base::CancelableTaskTracker* tracker); 448 base::CancelableTaskTracker* tracker);
449 449
450 // Adds or removes observers for the VisitDatabase. 450 // Adds or removes observers for the VisitDatabase.
451 void AddVisitDatabaseObserver(history::VisitDatabaseObserver* observer); 451 void AddVisitDatabaseObserver(history::VisitDatabaseObserver* observer);
452 void RemoveVisitDatabaseObserver(history::VisitDatabaseObserver* observer); 452 void RemoveVisitDatabaseObserver(history::VisitDatabaseObserver* observer);
453 453
454 void NotifyVisitDBObserversOnAddVisit(const history::BriefVisitInfo& info); 454 void NotifyVisitDBObserversOnAddVisit(const history::BriefVisitInfo& info);
455 455
456 // Testing ------------------------------------------------------------------- 456 // Testing -------------------------------------------------------------------
457 457
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
974 scoped_ptr<history::InMemoryURLIndex> in_memory_url_index_; 974 scoped_ptr<history::InMemoryURLIndex> in_memory_url_index_;
975 975
976 ObserverList<history::VisitDatabaseObserver> visit_database_observers_; 976 ObserverList<history::VisitDatabaseObserver> visit_database_observers_;
977 977
978 history::DeleteDirectiveHandler delete_directive_handler_; 978 history::DeleteDirectiveHandler delete_directive_handler_;
979 979
980 DISALLOW_COPY_AND_ASSIGN(HistoryService); 980 DISALLOW_COPY_AND_ASSIGN(HistoryService);
981 }; 981 };
982 982
983 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 983 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698