chrome/browser/sync/glue/typed_url_data_type_controller.cc - Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/typed_url_data_type_controller.cc

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert unnecessary changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/history_model_worker.cc ('k') | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/typed_url_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/typed_url_data_type_controller.cc b/chrome/browser/sync/glue/typed_url_data_type_controller.cc

index d6cd6274c50d6aea57eab958199c92dccf9cc12a..403d6b07b393439b484f2e219929852351027509 100644

--- a/chrome/browser/sync/glue/typed_url_data_type_controller.cc

+++ b/chrome/browser/sync/glue/typed_url_data_type_controller.cc

@@ -138,8 +138,10 @@ bool TypedUrlDataTypeController::PostTaskOnBackendThread(

HistoryService* history = HistoryServiceFactory::GetForProfile(

profile(), Profile::IMPLICIT_ACCESS);

if (history) {

- history->ScheduleDBTask(new RunTaskOnHistoryThread(task, this),

- &task_tracker_);

+ history->ScheduleDBTask(

+ scoped_ptr<history::HistoryDBTask>(

+ new RunTaskOnHistoryThread(task, this)),

+ &task_tracker_);

return true;

} else {

// History must be disabled - don't start.

« no previous file with comments | « chrome/browser/sync/glue/history_model_worker.cc ('k') | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »