chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert unnecessary changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index 0cef1e5ed58ebec2061f2204c06c45fe0acca655..e39e8bce6132943dff548a619efaad3817ceb527 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -38,8 +38,7 @@

namespace {

-class InlineSigninHelper : public SigninOAuthHelper,

- public SigninOAuthHelper::Consumer {

+class InlineSigninHelper : public SigninOAuthHelper::Consumer {

public:

InlineSigninHelper(

base::WeakPtr<InlineLoginHandlerImpl> handler,

@@ -61,6 +60,7 @@ class InlineSigninHelper : public SigninOAuthHelper,

virtual void OnSigninOAuthInformationFailure(

const GoogleServiceAuthError& error) OVERRIDE;

+ SigninOAuthHelper signin_oauth_helper_;

base::WeakPtr<InlineLoginHandlerImpl> handler_;

Profile* profile_;

GURL current_url_;

@@ -82,7 +82,8 @@ InlineSigninHelper::InlineSigninHelper(

const std::string& session_index,

const std::string& signin_scoped_device_id,

bool choose_what_to_sync)

- : SigninOAuthHelper(getter, session_index, signin_scoped_device_id, this),

+ : signin_oauth_helper_(getter, session_index, signin_scoped_device_id,

+ this),

handler_(handler),

profile_(profile),

current_url_(current_url),

« no previous file with comments | « chrome/browser/ui/sync/profile_signin_confirmation_helper.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »