chrome/browser/sync/test/integration/bookmarks_helper.cc - Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert unnecessary changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_typed_url_unittest.cc ('k') | chrome/browser/sync/test/integration/typed_urls_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/bookmarks_helper.cc

diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc

index 46d51b5180a8014bf8402de80ce7b4ada7b867b4..2cfb377a2fec72db46e286d3fd4f59ca084ea096 100644

--- a/chrome/browser/sync/test/integration/bookmarks_helper.cc

+++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc

@@ -268,7 +268,10 @@ void WaitForHistoryToProcessPendingTasks() {

HistoryServiceFactory::GetForProfileWithoutCreating(profile);

base::WaitableEvent done(false, false);

base::CancelableTaskTracker task_tracker;

- history_service->ScheduleDBTask(new HistoryEmptyTask(&done), &task_tracker);

+ history_service->ScheduleDBTask(

+ scoped_ptr<history::HistoryDBTask>(

+ new HistoryEmptyTask(&done)),

+ &task_tracker);

done.Wait();

}

// Wait such that any notifications broadcast from one of the history threads